repost of #79133: minor edtlib design improvements #80538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves several node-specific operations inside the Node class to improve its encapsulation, remove a monkey patch and access to internal methods and fields. Signed-off-by: Florian Grandel <[email protected]>
Small refactorings to simplify code and improve method encapsulation. Signed-off-by: Florian Grandel <[email protected]>
Adds type hints to functions that were not yet typed. Signed-off-by: Florian Grandel <[email protected]>
The return type of 'uint8-array' properties was not yet documented. Signed-off-by: Florian Grandel <[email protected]>
fabiobaltieri
approved these changes
Oct 29, 2024
|
bump |
kartben
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repost of #79133 since author github account was deleted