Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcux: drivers: XBARB: add possibility for XBARB #80225

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lam-borg
Copy link

Add the possibility to activate the XBARB driver
the same way as the XBARA driver

Copy link

Hello @lam-borg, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@lam-borg
Copy link
Author

related to this PR in hal_nxp: zephyrproject-rtos/hal_nxp#442

@zephyrbot
Copy link
Collaborator

zephyrbot commented Oct 23, 2024

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@dad9b28 zephyrproject-rtos/hal_nxp@d599b6f (master) zephyrproject-rtos/[email protected]

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Oct 23, 2024
@danieldegrasse
Copy link
Collaborator

Commit message for manifest update needs to include a signoff line, it should also be more specific (IE the title should mention that the NXP HAL is being updated)

@lam-borg
Copy link
Author

lam-borg commented Oct 24, 2024

I wasn't aware, its an issue if my PR on hal_nxp is behind main. But makes perfect sense, knowing its used for unit tests in the zephyr PR.

Now updated.

@lam-borg
Copy link
Author

Done.
The PR at hal_nxp was already up to date at the last force-push. Still some of the twister tests failed...

danieldegrasse
danieldegrasse previously approved these changes Oct 24, 2024
mmahadevan108
mmahadevan108 previously approved these changes Oct 24, 2024
@kartben
Copy link
Collaborator

kartben commented Oct 30, 2024

@lam-borg can you please rebase to resolve conflicts?

@lam-borg
Copy link
Author

@kartben both branches are rebased now

danieldegrasse
danieldegrasse previously approved these changes Oct 30, 2024
Copy link
Collaborator

@danieldegrasse danieldegrasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to merge after 4.0 release, as we are now in 4.0 feature freeze

@kartben kartben assigned dleach02 and mmahadevan108 and unassigned gmarull Dec 12, 2024
@dleach02
Copy link
Member

@lam-borg ping me on discord so we can sequence some merging.

@mmahadevan108
Copy link
Collaborator

mmahadevan108 commented Jan 18, 2025

@lam-borg, HAL side has been merged. We will need your help updating the HAL SHA.

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Jan 18, 2025
@lam-borg
Copy link
Author

I tried it in pure github ui, didnt work. I'll fix it within the next hour

Mathias Landolt added 2 commits January 18, 2025 20:51
Add the possibility to activate the XBARB driver
the same way as the XBARA driver

Signed-off-by: Mathias Landolt <[email protected]>
Update NXP HAL revision to include support for xbarb

Signed-off-by: Mathias Landolt <[email protected]>
Update the hal_nxp revision to the most recent revision, including the xbarb changes

Signed-off-by: Mathias Landolt <[email protected]>

tbs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants