Bluetooth: Mesh: Fixes after proxy advertising unable to send messages #79686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
akredalen,
alxelax,
Andrewpini,
HaavardRei,
jhedberg,
omkar3141 and
PavelVPV
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
27bc643 to
96cae34
Compare
LingaoM
added
the
Trivial
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
96cae34 to
f6f4799
Compare
PavelVPV
removed
the
Trivial
PavelVPV
requested changes
Oct 11, 2024
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
f6f4799 to
817fd4a
Compare
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
817fd4a to
67ff0fc
Compare
PavelVPV
reviewed
Oct 14, 2024
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
67ff0fc to
f6b29cb
Compare
When Proxy advertising or PB-GATT Advertising Enabled and use a same advertising sets. As adv\_start will call multi HCI Command will cause syswork_q yield. At same time, if another thread(BT RX) all schedule\_send will cause unable send mesh message, because ADV\_FLAG\_ACTIVE was be set, but ADV\_FLAG\_PROXY not set currentlly. Add ADV\_FLAG\_SCHEDULE\_PENDING indicate mesh buf has been pendings but not scheduled, so when proxy advertising enable, let's take again, as we can't break or terminated adv\_start, so we must waiting proxy advertising enabled. But after zephyrproject-rtos#68558 The `k_work_is_pending` always true in `send_pending_adv`, which cause unable to send more mesh message until more mesh message comming Signed-off-by: Lingao Meng <[email protected]>
LingaoM
force-pushed
the
fix_mesh_adv_ext
branch
from
f6b29cb to
612229e
Compare
PavelVPV
approved these changes
Oct 15, 2024
alxelax
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Proxy advertising or PB-GATT Advertising Enabled and use a same advertising sets.
As adv_start will call multi HCI Command will cause syswork_q yield. At same time, if another thread(BT RX) all schedule_send will cause unable send mesh message, because ADV_FLAG_ACTIVE was be set, but ADV_FLAG_PROXY not set currentlly.
Add ADV_FLAG_SCHEDULE_PENDING indicate mesh buf has been pendings but not scheduled, so when proxy advertising enable, let's take again, as we can't break or terminated adv_start, so we must waiting proxy advertising enabled.
But after #68558
The
k_work_is_pendingalways true insend_pending_adv, which cause unable to send more mesh message until more mesh message comming