[Backport v3.6-branch] posix: eventfd: Fix unsetting internal flags in ioctl #71460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit e6eb0a7 ("posix: eventfd: revise locking, signaling, and allocation") introduced a regression where the internal flags of an event file descriptor would be erased when calling the F_SETFL ioctl operation. This includes the flag EFD_IN_USE_INTERNAL which determines whether this file descriptor has been opened, thus effectively closing the eventfd whenever one tries to change a flag. Signed-off-by: Celina Sophie Kalus <[email protected]> (cherry picked from commit 5bd86ea)
Add a test to protect against future regressions in the ioctl F_SETFL operation of eventfd. Flags are set and unset and validity of the file descriptor is checked by reading and writing. Signed-off-by: Celina Sophie Kalus <[email protected]> (cherry picked from commit 325f22a)
zephyrbot
added
Backport
ycsin
approved these changes
Apr 13, 2024
cfriedt
approved these changes
Apr 13, 2024
henrikbrixandersen
approved these changes
Apr 22, 2024
MaureenHelm
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 325f22a~2..325f22a from #71344.
Fixes #71399