[Backport v3.6-branch] Bluetooth: Check buffer length in GATT rsp functions #70869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
Backport
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
Thalley
approved these changes
Mar 29, 2024
alwa-nordic
approved these changes
Mar 29, 2024
jhedberg
approved these changes
Mar 29, 2024
jori-nordic
approved these changes
Apr 2, 2024
|
This needs a bug report in order to be backported - and the BSIM tests are failing in CI? |
|
@henrikbrixandersen This is a fix for a Security Advisories, so it does not have a ticket on the issue tracker. Please advise. I think the BSim is timing out because our CI was switched out for a potato :)
|
@alwa-nordic looks like the connection for the BSIM was just dropped. Shouldn't we just re-run it? |
It failed again. It look to me like the full parallel build is grinding the machine to a halt or running OOM. @aescolar Do you agree with my suspicion? |
It could easily be. This branch still runs too many compile jobs in parallel (which we do no do in main for a while now). Maybe add to this PR an equivalent to the backport of 65d49cd |
|
@henrikbrixandersen I created an issue for this backport. |
There are quite many BT host test images being built. Today these are all built in parallel, causing a quite high load. Let's split them in their separate sub-scripts, so we don't parallelize too many builds, and users have more granularity if they only want to build a subset. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit 65d49cd) Signed-off-by: Alberto Escolar Piedras <[email protected]>
The CIS tests are building quite many apps on their own. Let's split them in their separate sub-script, so we don't parallelize too many builds, and users have more granularity if they only want to build a subset. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit 940d53e) Signed-off-by: Alberto Escolar Piedras <[email protected]>
One of these tests has been seen failing in older slower computers due to timeouts, let's increase the timeout so we don't break in those cases. Note this timeout is just a safety to eventually kill hung simulations even if nobody presses Ctrl+C. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit d592455) Signed-off-by: Alberto Escolar Piedras <[email protected]>
This test has been seen failing in older slower computers due to timeouts, let's increase the timeout so we don't break in those cases. Note this timeout is just a safety to eventually kill hung simulations even if nobody presses Ctrl+C. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit e9c8856) Signed-off-by: Alberto Escolar Piedras <[email protected]>
This test has been seen failing in older slower computers due to timeouts, let's increase the timeout so we don't break in those cases. Note this timeout is just a safety to eventually kill hung simulations even if nobody presses Ctrl+C. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit 0888882) Signed-off-by: Alberto Escolar Piedras <[email protected]>
This test has been seen failing in the new runners due to a (realtime) timeout. Let's double the timeout so it does not. Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit f497234) Signed-off-by: Alberto Escolar Piedras <[email protected]>
This test keeps its own partial way of running tests. Let's have it kill stuck processes in the same way as the rest (sending another kill 5 seconds after, and printing a message about what happened) Signed-off-by: Alberto Escolar Piedras <[email protected]> (cherry picked from commit 693ae86) Signed-off-by: Alberto Escolar Piedras <[email protected]>
Add length checks local to the parsing function. This removes the need for a separate data validation step. Signed-off-by: Aleksander Wasaznik <[email protected]> (cherry picked from commit 3eeb8f8)
aescolar
force-pushed
the
backport-69396-to-v3.6-branch
branch
from
e2866fb to
9cb1059
Compare
zephyrbot
requested review from
carlescufi,
cvinayak,
kruithofa,
mtpr-ot,
thoh-ot and
wopu-ot
|
I just pushed an update to this PR, to include the changes we did in main to:
|
|
@henrikbrixandersen @MaureenHelm CI is green here now. |
henrikbrixandersen
approved these changes
May 2, 2024
MaureenHelm
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3eeb8f8 from #69396.
Fixes: GHSA-gmfv-4vfh-2mh8
Fixes: #72140