Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v3.6-branch] doc: release: migration guide v3.6.0: Fix GH link #70739

Merged
merged 1 commit into from
Apr 3, 2024
Merged

[Backport v3.6-branch] doc: release: migration guide v3.6.0: Fix GH link #70739

merged 1 commit into from
Apr 3, 2024

Conversation

zephyrbot
Copy link
Collaborator

@zephyrbot zephyrbot commented Mar 26, 2024 •
edited by henrikbrixandersen
Loading

Backport 5a49b7c from #70700.

Fixes: #70988

@rettichschnidi @github-actions
doc: releases: Fix GH link in migration guide v3.6
85dd94f 
Putting a space between :github: and the PR number causes the rendered
text to not link to the issue.

Signed-off-by: Reto Schneider <[email protected]>
(cherry picked from commit 5a49b7c)
@zephyrbot zephyrbot added Backport Backport PR and backport failure issues Release Notes To be mentioned in the release notes Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. labels Mar 26, 2024
@MaureenHelm
Copy link
Member

@rettichschnidi

ERROR:root:https://github.com/zephyrproject-rtos/zephyr/pull/70739 does not have an associated issue
ERROR:root:Please ensure the body of each PR to a release branch contains "Fixes #[12](https://github.com/zephyrproject-rtos/zephyr/actions/runs/8436179084/job/23103136873?pr=70739#step:4:13)34"
ERROR:root:The following PRs are lacking associated issues:
ERROR:root:https://github.com/zephyrproject-rtos/zephyr/pull/70739

@rettichschnidi
Copy link
Contributor

I would not know how I could do anything about this here. It was my commit, but this here is not my PR.

@henrikbrixandersen henrikbrixandersen linked an issue Apr 2, 2024 that may be closed by this pull request
[v3.6-branch] doc: Documentation issue in 'releases/migration-guide-3.6' #70988
Closed
@henrikbrixandersen henrikbrixandersen added this to the v3.6.1 milestone Apr 2, 2024
@henrikbrixandersen
Copy link
Member

I would not know how I could do anything about this here. It was my commit, but this here is not my PR.

I added a backport label to your original PR. I have just created a corresponding issue in order to get this backported to v3.6-branch.

@MaureenHelm MaureenHelm merged commit c719aed into v3.6-branch Apr 3, 2024
18 checks passed
@henrikbrixandersen henrikbrixandersen mentioned this pull request Jun 2, 2024
Closed
@nashif nashif deleted the backport-70700-to-v3.6-branch branch November 16, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@thedjnK thedjnK thedjnK approved these changes

@henrikbrixandersen henrikbrixandersen henrikbrixandersen approved these changes

@kartben kartben Awaiting requested review from kartben

Assignees

@MaureenHelm MaureenHelm

Labels
Backport Backport PR and backport failure issues Release Notes To be mentioned in the release notes Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
Backports
Status: Done
Milestone
v3.6.1
Development

Successfully merging this pull request may close these issues.

[v3.6-branch] doc: Documentation issue in 'releases/migration-guide-3.6'
5 participants
@zephyrbot @MaureenHelm @rettichschnidi @henrikbrixandersen @thedjnK