Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: _scripts: redirects: fix redirect for led_strip samples #70665

Merged

Conversation

soburi
Copy link
Member

@soburi soburi commented Mar 25, 2024

Since I have integrated some samples into samples/drivers/led_strip,
seting up redirection from the deleted apa102, lpd8806, and ws2812.

Signed-off-by: TOKITA Hiroshi [email protected]

@soburi soburi added the DNM This PR should not be merged (Do Not Merge) label Mar 25, 2024
@soburi soburi force-pushed the redirect_led_strip_samples branch 5 times, most recently from bfa659f to 599d514 Compare March 25, 2024 23:49
@soburi soburi changed the title doc: _scripts: redirects: fix redirect for les_strip samples doc: _scripts: redirects: fix redirect for led_strip samples Mar 25, 2024
@soburi
Copy link
Member Author

soburi commented Mar 25, 2024

@kartben

#70023 (comment)

I have set up a redirect.
Since I didn't know how to run a web server myself, I couldn't confirm its operation.

@soburi soburi removed the DNM This PR should not be merged (Do Not Merge) label Mar 25, 2024
@soburi soburi marked this pull request as ready for review March 25, 2024 23:54
@soburi soburi requested a review from carlescufi as a code owner March 25, 2024 23:54
@zephyrbot zephyrbot requested review from gmarull, kartben and nashif March 25, 2024 23:55
gmarull
gmarull previously approved these changes Mar 26, 2024
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for following up with this!
Spotted a typo, but works as expected otherwise (ex. https://builds.zephyrproject.io/zephyr/pr/70665/docs/samples/drivers/led_apa102/README.html)

doc/_scripts/redirects.py Outdated Show resolved Hide resolved
Since I have integrated some samples into samples/drivers/led_strip,
seting up redirection from the deleted apa102, lpd8806, and ws2812.

Signed-off-by: TOKITA Hiroshi <[email protected]>
@soburi soburi requested a review from gmarull March 26, 2024 18:41
@fabiobaltieri fabiobaltieri merged commit ddf3182 into zephyrproject-rtos:main Mar 28, 2024
16 checks passed
@soburi soburi deleted the redirect_led_strip_samples branch April 30, 2024 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants