tests: net: buf: Fix cloning of zero-sized buffers #70585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Networking
area: Networking Buffers
zephyrbot
requested review from
jhedberg,
jukkar,
pdgendt,
rlubos,
ssharks and
tbursztyka
rettichschnidi
force-pushed
the
gardena/rs/upstream/net-buf-fix-clone-reference-counted-zero-sized-buffer
branch
from
c0a5ab0 to
f086d59
Compare
jukkar
previously approved these changes
Mar 23, 2024
rettichschnidi
force-pushed
the
gardena/rs/upstream/net-buf-fix-clone-reference-counted-zero-sized-buffer
branch
from
f086d59 to
88e7e49
Compare
|
Rebased because of a conflict. |
jhedberg
approved these changes
Mar 24, 2024
rlubos
approved these changes
Mar 25, 2024
pdgendt
approved these changes
Mar 25, 2024
rettichschnidi
force-pushed
the
gardena/rs/upstream/net-buf-fix-clone-reference-counted-zero-sized-buffer
branch
from
88e7e49 to
289d49d
Compare
Done |
The first commit subject shouldn't start with |
For zero sized buffers, instead of pointing to a buffer, net_buf->__buf is NULL. For this reason, when cloning a buffer, the code needs to check __buf before dereferencing it. Signed-off-by: Reto Schneider <[email protected]>
This commit ensures that copying a zero-sized buffer works. Signed-off-by: Reto Schneider <[email protected]>
rettichschnidi
force-pushed
the
gardena/rs/upstream/net-buf-fix-clone-reference-counted-zero-sized-buffer
branch
from
289d49d to
dbbd9fc
Compare
jukkar
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For zero sized buffers, instead of pointing to a buffer, net_buf->__buf
is NULL. For this reason, when cloning a buffer, the code needs to check
__buf before dereferencing it.