input: pat912x: add a bunch of settings #69636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiobaltieri
requested review from
kartben,
faxe1008,
aasinclair,
gmarull and
bjarki-andreasen
zephyrbot
added
area: Devicetree Binding
bjarki-andreasen
previously approved these changes
Mar 1, 2024
faxe1008
previously approved these changes
Mar 1, 2024
fabiobaltieri
dismissed stale reviews from faxe1008 and bjarki-andreasen
via
c2163cf
Add devicetree based settings for resolution, axis inversion and sleep mode enable. Keep the resolution setting in its own function so it can be called by the application again in runtime if needed. Signed-off-by: Fabio Baltieri <[email protected]>
gmarull
reviewed
Mar 1, 2024
Comment on lines
+328
to
+331
| BUILD_ASSERT(IN_RANGE(DT_INST_PROP(n, res_x_cpi), 0, RES_MAX), \ | ||
| "invalid res-x-cpy"); \ | ||
| BUILD_ASSERT(IN_RANGE(DT_INST_PROP(n, res_y_cpi), 0, RES_MAX), \ | ||
| "invalid res-y-cpy"); \ |
There was a problem hiding this comment.
it would be nice if a generous soul introduced min/max setting in our binding language. @fabiobaltieri maybe :-) ?
There was a problem hiding this comment.
You know what this project really needs? Interns.
There was a problem hiding this comment.
You know what this project really needs? Interns.
You mean like .. Summer of Code? :)
gmarull
approved these changes
Mar 1, 2024
faxe1008
approved these changes
Mar 1, 2024
aasinclair
approved these changes
Mar 1, 2024
bjarki-andreasen
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second and last round for this interesting device, adds support for axis inversion, resolution settings at init and runtime and sleep mode.
Oddly enough, according to the datasheet some of these registers should be write protected and need another register to be unlocked, but my device does not seem to be bothered, not too sure why but I think it's fine to leave it as is for the moment and keep the code a bit simpler.
Add devicetree based settings for resolution, axis inversion and sleep mode enable. Keep the resolution setting in its own function so it can be called by the application again in runtime if needed.