Bluetooth: HFP: Fix session pointer invalid issue #69591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc,
Thalley and
theob-pro
jori-nordic
approved these changes
Feb 29, 2024
jhedberg
changed the title
|
@lylezhu2012 since this is about a specific profile (HFP), I think it'd be more appropriate to use "Bluetooth: HFP: ..." in the commit title instead of "Bluetooth: Host: ...". I already fixed it for the PR title, but could you do the same for the commit too? Thanks. |
The dlc->session is invalid in the callback hfp_hf_disconnected. The behavior of obtaining an ACL connection handle through an invalid pointer is unknown. Add a field "struct bt_conn *acl" to "struct bt_hfp_hf". Save acl connect handle to "struct bt_hfp_hf::acl" in function bt_hfp_hf_accept. Signed-off-by: Lyle Zhu <[email protected]>
Yes. It is done. |
jhedberg
approved these changes
Feb 29, 2024
Thalley
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dlc->session is invalid in the callback hfp_hf_disconnected. The behavior of obtaining an ACL connection handle through an invalid pointer is unknown.
Add a field "struct bt_conn *acl" to "struct bt_hfp_hf". Save acl connect handle to "struct bt_hfp_hf::acl" in function bt_hfp_hf_accept.