scripts: ci: check_compliance: fix split on ":" for Windows #69587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method get_kconfig_dts() relies on str's split() to split
lines into fields separated by ':'. The second field is an
absolute path to a file.
On Windows, an absolute path includes a drive's letter followed
by ':' which breaks the current code.
On Linux, although rare, a file or directory name may also include
':', which would also break the code.
The fix is to constraint the number of splits to 1.
The code then becomes:
_,b = line.split(":", 1)
Signed-off-by: Yves Vandervennet <[email protected]>
zephyrbot
added
Trivial
zephyrbot
requested review from
carlescufi,
fabiobaltieri,
jfischer-no,
kartben,
keith-zephyr,
nashif and
stephanosio
fabiobaltieri
approved these changes
Feb 28, 2024
stephanosio
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method get_kconfig_dts() relies on str's split() to split lines into fields separated by ':'. The second field is an absolute path to a file.
On Windows, an absolute path includes a drive's letter followed by ':' which breaks the current code.
On Linux, although rare, a file or directory name may also include ':', which would also break the code.
The fix is to constraint the number of splits to 1. The code then becomes:
_,b = line.split(":", 1)