Bluetooth: Mesh: Prevent duplicate cdb appkeys #69571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
4c0acde to
084cbcd
Compare
akredalen
previously approved these changes
Feb 28, 2024
alxelax
requested changes
Feb 28, 2024
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
084cbcd to
1e6dbc8
Compare
alxelax
previously approved these changes
Feb 28, 2024
jhedberg
previously approved these changes
Feb 29, 2024
PavelVPV
reviewed
Feb 29, 2024
PavelVPV
requested changes
Feb 29, 2024
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
1e6dbc8 to
8d26e90
Compare
alxelax
reviewed
Feb 29, 2024
PavelVPV
reviewed
Feb 29, 2024
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
8d26e90 to
c036680
Compare
|
I need to revise my fix, there is an issue for app_idx=0 now since this is the value all entries have before they are taken into use. |
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
c036680 to
25c26ff
Compare
alxelax
requested changes
Feb 29, 2024
Fixes issue where it is possible to store the same appkey multiple times in CDB implementation. Signed-off-by: Anders Storrø <[email protected]>
Andrewpini
force-pushed
the
fix_mesh_shell_cdb_appkey_add_duplicate_issue
branch
from
25c26ff to
d9d66a5
Compare
alxelax
approved these changes
Feb 29, 2024
PavelVPV
approved these changes
Feb 29, 2024
| @@ -94,6 +94,7 @@ struct bt_mesh_cdb bt_mesh_cdb = { | |||
| }, | |||
| .app_keys = { | |||
| [0 ... (CONFIG_BT_MESH_CDB_APP_KEY_COUNT - 1)] = { | |||
| .app_idx = BT_MESH_KEY_UNUSED, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where it is possible to store the same appkey multiple times in CDB implementation.