ec_host_cmd: introduce Host Command state #69560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: ec_host_cmd
Trivial
niedzwiecki-dawid
requested review from
duda-patryk,
keith-zephyr and
fabiobaltieri
fabiobaltieri
previously approved these changes
Feb 28, 2024
duda-patryk
approved these changes
Feb 28, 2024
|
Sorry for disturbing, I've changed me mind and I'll upload checking HC state in the general code, for all backends. |
niedzwiecki-dawid
added
the
In progress
niedzwiecki-dawid
force-pushed
the
hc_send_twice
branch
from
84db678 to
73fd1d4
Compare
niedzwiecki-dawid
changed the title
niedzwiecki-dawid
removed
the
Trivial
fabiobaltieri
previously approved these changes
Feb 29, 2024
duda-patryk
approved these changes
Feb 29, 2024
keith-zephyr
reviewed
Mar 5, 2024
Introduce a current state of Host Command subsystem. It makes sures that a backend has been initilized and doesn't allow sending a response twice. There is a possibility, that a command handler that calls ec_host_cmd_send_response function returns anyway (which is a mistake). Signed-off-by: Dawid Niedzwiecki <[email protected]>
niedzwiecki-dawid
force-pushed
the
hc_send_twice
branch
from
73fd1d4 to
4d4cd74
Compare
fabiobaltieri
approved these changes
Mar 6, 2024
keith-zephyr
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes sures that a backend has been initilized and doesn't allow
sending a response twice. There is a possibility, that a command handler
that calls ec_host_cmd_send_response function returns anyway (which is a
mistake).