drivers: can: add support for minimum supported bitrates #69533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrikbrixandersen
added
area: CAN
Release Notes Required
henrikbrixandersen
force-pushed
the
can_min_bitrate
branch
3 times, most recently
from
e095e60 to
99aed69
Compare
henrikbrixandersen
removed
the
Release Notes Required
henrikbrixandersen
requested review from
alexanderwachter,
aaillet,
karstenkoenig,
manuargue,
erwango,
ABOSTM,
FRASTM,
mmahadevan108 and
dleach02
as code owners
zephyrbot
requested review from
avisconti,
galak,
jfischer-no,
kartben,
martinjaeger and
str4t0m
str4t0m
requested changes
Mar 4, 2024
henrikbrixandersen
force-pushed
the
can_min_bitrate
branch
2 times, most recently
from
e4e60fc to
2160751
Compare
henrikbrixandersen
force-pushed
the
can_min_bitrate
branch
from
2160751 to
7880feb
Compare
|
Rebased to resolve merge conflict in |
|
@str4t0m PTAL |
str4t0m
previously approved these changes
Mar 6, 2024
Some CAN transceivers have a lower limit on their supported bitrate. Add an optional "min-bitrate" for specifying this limit via devicetree. Signed-off-by: Henrik Brix Andersen <[email protected]>
The NXP TJA1050 supports bitrates from 60kbit/s up to 1Mbit/s. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add support for getting the minimum supported bitrate of a CAN transceiver. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add tests for DT_CAN_TRANSCEIVER_MIN_BITRATE() and DT_INST_CAN_TRANSCEIVER_MIN_BITRATE(). Signed-off-by: Henrik Brix Andersen <[email protected]>
Add support for specifying the minimum bitrate supported by a CAN controller in CAN_DT_DRIVER_CONFIG_GET() and CAN_DT_DRIVER_CONFIG_INST_GET(). Signed-off-by: Henrik Brix Andersen <[email protected]>
Allow frontend drivers based on the SJA1000 backend to specify a minimum supported bitrate. The ESP32 TWAI supports bitrates from 25kbit/s to 1Mbit/s. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add a new CAN controller API function can_get_min_bitrate() for getting the minimum supported bitrate of a CAN controller/transceiver combination. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add test for validating the CAN controller bitrate limits. Signed-off-by: Henrik Brix Andersen <[email protected]>
Take the minimum supported bitrate into consideration when validating the bitrate. Signed-off-by: Henrik Brix Andersen <[email protected]>
Enable testing of all bitrates for all drivers and report which bitrates are not supported by the CAN controller under test. Signed-off-by: Henrik Brix Andersen <[email protected]>
Add release notes related to the added support for minimum supported CAN transceiver/controller bitrates. Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
force-pushed
the
can_min_bitrate
branch
from
7880feb to
86fdff4
Compare
|
Rebased to resolve merge conflict in |
str4t0m
approved these changes
Mar 7, 2024
aasinclair
approved these changes
Mar 12, 2024
| @@ -363,7 +366,7 @@ int z_impl_can_set_bitrate(const struct device *dev, uint32_t bitrate) | |||
| return ret; | |||
| } | |||
|
|
|||
| if ((max_bitrate > 0) && (bitrate > max_bitrate)) { | |||
| if ((bitrate < min_bitrate) || (((max_bitrate > 0) && (bitrate > max_bitrate)))) { | |||
There was a problem hiding this comment.
nit: Is the check for max_bitrate of zero needed here? It is marked as required.
There was a problem hiding this comment.
Thank you for reviewing! Currently, it is needed. It will go away in a future revision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CAN controllers and CAN transceivers have a lower limit for which bitrates they support.
In-tree examples:
This patch series adds:
can_get_min_bitrate()API function (+ tests) for getting the minimum supported bitrate for a given CAN controller/transceiver combo.