drivers: input: pinnacle: add driver for Cirque Pinnacle 1CA027 based trackpads #69438
Conversation
akscram
force-pushed
the
driver-input-pinnacle
branch
5 times, most recently
from
ec84e34 to
b1fa8b0
Compare
zephyrbot
added
area: Devicetree Binding
zephyrbot
requested review from
fabiobaltieri,
galak,
gmarull,
kartben and
nashif
|
@akscram I'm so sorry, just misclicked on my phone and inadvertently marked this as ready for review :( |
|
@kartben, no problem at all. I think the PR is more or less ready for the first round of review, if it's okay to implement more features, such as the relative mode, taps detection and so on, in follow up PRs. |
|
cc @petejohanson, there's some existing work on zmkfirmware/zmk#2035 for this, ideally we'd converge on a common solution, not looking for features right now just a solid base, also I got a TM040040 myself as well. :-) |
akscram
force-pushed
the
driver-input-pinnacle
branch
from
b1fa8b0 to
adb45b8
Compare
|
@fabiobaltieri, thank you for the early review. Your comments should be addressed now. |
samples/subsys/input/input_dump/boards/nrf52dk_nrf52832.overlay
Outdated
Show resolved
Hide resolved
akscram
force-pushed
the
driver-input-pinnacle
branch
4 times, most recently
from
59f4643 to
b50f78c
Compare
akscram
force-pushed
the
driver-input-pinnacle
branch
from
b50f78c to
1de3d09
Compare
drivers/input/input_pinnacle.c
Outdated
| input_report_abs(dev, INPUT_ABS_X, sample->x, false, K_FOREVER); | ||
| input_report_abs(dev, INPUT_ABS_Y, sample->y, false, K_FOREVER); | ||
| input_report_abs(dev, INPUT_ABS_Z, sample->z, true, K_FOREVER); | ||
| #elif defined(CONFIG_INPUT_PINNACLE_DATA_MODE_RELATIVE) | ||
| input_report_abs(dev, INPUT_REL_X, sample->x, false, K_FOREVER); | ||
| input_report_abs(dev, INPUT_REL_Y, sample->y, true, K_FOREVER); |
There was a problem hiding this comment.
The controller indeed supports swapping X and Y (90 degrees rotation, by default the rotation is 0 degrees). I will need to try this out before I could come up with a proper configuration.
I'm not sure I fully understand what exactly you're asking to make configurable. Are you suggesting to make the swapping of axes configurable?
akscram
force-pushed
the
driver-input-pinnacle
branch
2 times, most recently
from
d2fdd3d to
98d60e5
Compare
akscram
force-pushed
the
driver-input-pinnacle
branch
from
98d60e5 to
39d2a06
Compare
akscram
force-pushed
the
driver-input-pinnacle
branch
2 times, most recently
from
2929bfb to
321a1ee
Compare
|
@fabiobaltieri, could you please take another look? |
akscram
force-pushed
the
driver-input-pinnacle
branch
2 times, most recently
from
73e577e to
5929844
Compare
akscram
force-pushed
the
driver-input-pinnacle
branch
2 times, most recently
from
43b2d08 to
5372963
Compare
The initial version of an input driver for Cirque Pinnacle ASIC supports: * Setting sensitivity * Choosing between relative and absolute modes * Relative mode * Primary tap * Swapping X and Y * Absolute mode * Setting number of idle packets * Clipping coordinates outside of active range * Scaling coordinates * Inverting X and Y coordinates Signed-off-by: Ilia Kharin <[email protected]>
akscram
force-pushed
the
driver-input-pinnacle
branch
from
5372963 to
503c676
Compare
|
Hi @akscram! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
Introduce an initial version of an input driver for Cirque Pinnacle GlidePoint circle trackpads connected via SPI, such as TM035035 and similar. The driver support only the absolute mode in which an absolute coordinates are reported. The relative mode is going to be the next step.