Modules: LVGL: Add Support for Rounder Callback #69410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: LVGL
zephyrbot
requested review from
andrzej-kaczmarek,
brgl,
faxe1008 and
pdgendt
|
@danieldegrasse could you also provide your input on this PR? |
faxe1008
requested changes
Feb 24, 2024
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
bdadebe to
06c0416
Compare
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
06c0416 to
a465928
Compare
faxe1008
reviewed
Feb 26, 2024
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
2 times, most recently
from
a465928 to
9699c21
Compare
faxe1008
previously approved these changes
Feb 27, 2024
pdgendt
reviewed
Feb 27, 2024
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
7513c39 to
9944482
Compare
pdgendt
previously approved these changes
Feb 27, 2024
faxe1008
previously approved these changes
Feb 27, 2024
andrzej-kaczmarek
previously approved these changes
Feb 27, 2024
nordicjm
requested changes
Mar 4, 2024
Hi, it's not clear to me what this scheme is. In fact, I am now unable to boot with any sample code after the introduction of hwmv2. |
ioannis-karachalios
dismissed stale reviews from faxe1008 and pdgendt
via
f7e2678
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
9944482 to
f7e2678
Compare
ioannis-karachalios
requested review from
nordicjm,
faxe1008,
andrzej-kaczmarek and
pdgendt
PR has been rebased |
pdgendt
previously approved these changes
Mar 4, 2024
nordicjm
previously requested changes
Mar 4, 2024
Add support for LVGL rounder callback function. Sometimes, either the underlying display controller and/or the LCD host controller might impose restrictions on frame resolution. For instance, the E1394AA65A display model should impose that either axis of a frame be multiple of 2 pixels or the Renesas LCD controller of the DA1469x SoC, should impose that the stride value, number of bytes between consecutive frame lines, be multiple of 4 bytes. Signed-off-by: Ioannis Karachalios <[email protected]>
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
f7e2678 to
718ffb1
Compare
pdgendt
reviewed
Mar 4, 2024
| @@ -0,0 +1,12 @@ | |||
| # DA1469x series Development Kit Pro board configuration | |||
|
|
|||
| # Copyright (c) 2022 Renesas Electronics Corporation | |||
Add default LVGL Kconfig for rounder cb. Signed-off-by: Ioannis Karachalios <[email protected]>
ioannis-karachalios
force-pushed
the
module-lvgl-rounder-cb
branch
from
718ffb1 to
1631643
Compare
pdgendt
approved these changes
Mar 4, 2024
andrzej-kaczmarek
approved these changes
Mar 4, 2024
faxe1008
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for LVGL frame rounder callback function. Sometimes, either the underlying display controller and/or the LCD host controller might impose restrictions on frames resolution. For instance, the E1394AA65A display model should impose that either axis of a frame be multiple of 2 pixels or the Renesas LCD controller of the DA1469x SoC, should impose that the stride value, number of bytes between consecutive frame lines, be multiple of 4 bytes.