samples: Bluetooth: Add stereo support for broadcast audio sink #69341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thalley
force-pushed
the
broadcast_sink_sample_stereo
branch
6 times, most recently
from
493e0d0 to
5dff1a7
Compare
Thalley
force-pushed
the
broadcast_sink_sample_stereo
branch
2 times, most recently
from
e4ab068 to
d629a3a
Compare
Thalley
requested review from
fredrikdanebjer,
larsgk,
cvinayak,
MariuszSkamra,
kruithofa,
Casper-Bonde-Bose and
pin-zephyr
zephyrbot
requested review from
asbjornsabo,
hermabe,
jhedberg,
kartben,
nashif,
sjanc and
Vudentz
cvinayak
previously approved these changes
Mar 8, 2024
kruithofa
previously approved these changes
Mar 11, 2024
larsgk
previously approved these changes
Mar 11, 2024
There was a problem hiding this comment.
LGTM but didn't try it out. Did you try with stereo/mono sources? - also, maybe @fredrikdanebjer should have a look
It has been tested with LEFT, RIGHT and LEFT | RIGHT (with 2 BIS), but not LEFT | RIGHT on a single BIS (I don't have a broadcast source that supports that to test) |
| @@ -35,6 +35,13 @@ config TARGET_BROADCAST_NAME | |||
| Name of target broadcast device. If not empty string, sink device | |||
| will only listen to the specified broadcast source. Not case sensitive. | |||
|
|
|||
| config MAX_CODEC_FRAMES_PER_SDU | |||
| int "The maximum number of codec frame per SDU supported" | |||
| default 1 | |||
The broadcast audio sink now supports stereo if CONFIG_TARGET_BROADCAST_CHANNEL=3 (LEFT | RIGHT). It parses the BASE to find a set of BIS (1 or 2) that contain the channel allocation from CONFIG_TARGET_BROADCAST_CHANNEL. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
broadcast_sink_sample_stereo
branch
from
d629a3a to
dd1102d
Compare
larsgk
approved these changes
Mar 12, 2024
fredrikdanebjer
approved these changes
Mar 12, 2024
cvinayak
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The broadcast audio sink now supports stereo if
CONFIG_TARGET_BROADCAST_CHANNEL=3 (LEFT | RIGHT).
It parses the BASE to find a set of BIS (1 or 2) that contain
the channel allocation from CONFIG_TARGET_BROADCAST_CHANNEL.