samples: net: cellular_modem: fine tuning #69288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Samples
zephyrbot
requested review from
bjarki-andreasen,
galak,
jukkar,
kartben,
nashif,
rerickson1,
rlubos,
ssharks and
tbursztyka
tomi-font
changed the title
tomi-font
force-pushed
the
modem_fine_tuning
branch
3 times, most recently
from
898f898 to
5218ac5
Compare
tomi-font
added a commit
to tomi-font/ncs-zephyr
that referenced
this pull request
Feb 22, 2024
…ropped Upstream PR: zephyrproject-rtos/zephyr#69288 When a receive buffer overrun happens. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
added a commit
to tomi-font/ncs-zephyr
that referenced
this pull request
Feb 22, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
added a commit
to tomi-font/ncs-zephyr
that referenced
this pull request
Feb 22, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 - A small delay is added after the post-restart L4_CONNECTED event is received to prevent trying to send packets too quickly. Otherwise the first packet would not get sent and the sample would hang on recv(). - Some logs and function parameters are fixed. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
added a commit
to tomi-font/ncs-zephyr
that referenced
this pull request
Feb 22, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 The added configuration files allow the sample to be run on the nRF52840 present on the nRF9160 DK with the nRF9160 (running SLM) being the modem and communication happening through pins that are routed internally between the two. Signed-off-by: Tomi Fontanilles <[email protected]>
bjarki-andreasen
previously approved these changes
Feb 22, 2024
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Feb 23, 2024
…ropped Upstream PR: zephyrproject-rtos/zephyr#69288 When a receive buffer overrun happens. Signed-off-by: Tomi Fontanilles <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Feb 23, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]>
rlubos
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Feb 23, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 The added configuration files allow the sample to be run on the nRF52840 present on the nRF9160 DK with the nRF9160 (running SLM) being the modem and communication happening through pins that are routed internally between the two. Signed-off-by: Tomi Fontanilles <[email protected]>
jukkar
previously approved these changes
Feb 26, 2024
kartben
previously approved these changes
Feb 26, 2024
| @@ -18,7 +18,7 @@ Notes | |||
|
|
|||
| This sample uses the devicetree alias modem to identify | |||
There was a problem hiding this comment.
nit
Suggested change
| This sample uses the devicetree alias modem to identify | |
| This sample uses the devicetree alias ``modem`` to identify |
When a receive buffer overrun happens. Signed-off-by: Tomi Fontanilles <[email protected]>
A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]>
- A small delay is added after the post-restart L4_CONNECTED event is received to prevent trying to send packets too quickly. Otherwise the first packet would not get sent and the sample would hang on recv(). - Some logs and function parameters are fixed. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
dismissed stale reviews from kartben, jukkar, and bjarki-andreasen
via
cad4cf3
tomi-font
force-pushed
the
modem_fine_tuning
branch
from
5218ac5 to
cad4cf3
Compare
The added configuration files allow the sample to be run on the nRF52840 present on the nRF9160 DK with the nRF9160 (running SLM) being the modem and communication happening through pins that are routed internally between the two. Signed-off-by: Tomi Fontanilles <[email protected]>
tomi-font
force-pushed
the
modem_fine_tuning
branch
from
cad4cf3 to
f76b9f6
Compare
|
Applied Benjamin's suggestion, rebased, and fixed a warning. |
bjarki-andreasen
approved these changes
Mar 4, 2024
jukkar
approved these changes
Mar 4, 2024
jfischer-no
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Mar 8, 2024
…ropped Upstream PR: zephyrproject-rtos/zephyr#69288 When a receive buffer overrun happens. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit 73c4577)
jfischer-no
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Mar 8, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit f7718c3)
jfischer-no
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Mar 8, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 - A small delay is added after the post-restart L4_CONNECTED event is received to prevent trying to send packets too quickly. Otherwise the first packet would not get sent and the sample would hang on recv(). - Some logs and function parameters are fixed. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit 86d6106)
jfischer-no
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Mar 8, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 The added configuration files allow the sample to be run on the nRF52840 present on the nRF9160 DK with the nRF9160 (running SLM) being the modem and communication happening through pins that are routed internally between the two. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit 40a1478)
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Mar 14, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit f7718c3) (cherry picked from commit 4c36459) Signed-off-by: Robert Lubos <[email protected]>
rlubos
pushed a commit
to rlubos/sdk-zephyr
that referenced
this pull request
Mar 21, 2024
Upstream PR: zephyrproject-rtos/zephyr#69288 A shutdown lasting more than 5 seconds was experienced. Signed-off-by: Tomi Fontanilles <[email protected]> (cherry picked from commit f7718c3) (cherry picked from commit 4c36459) Signed-off-by: Robert Lubos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in commit messages.