Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hwmv2 boards: arm: Add support for WeAct Studio MiniSTM32H743 Core board #69267

Merged
merged 1 commit into from
Apr 2, 2024
Merged

hwmv2 boards: arm: Add support for WeAct Studio MiniSTM32H743 Core board #69267

merged 1 commit into from
Apr 2, 2024

Conversation

CharlesDias
Copy link
Contributor

@CharlesDias CharlesDias commented Feb 20, 2024 •
edited
Loading

Adds the device trees, Kconfig, and documentation files.

The following features have been confirmed working on hardware:

  • LED
  • Button
  • USB CDC ACM
  • External QuadSPI NOR Flash memory
  • External SPI NOR Flash memory
  • SDMMC
  • TFT-LCD 160x80 pixel

The following sample codes were used to validate:

  • samples/basic/blinky
  • samples/basic/button/
  • samples/hello_world
  • samples/subsys/shell/shell_module/
  • samples/drivers/spi_flash
  • samples/drivers/flash_shell/
  • samples/subsys/display/lvgl

nordicjm
nordicjm requested changes Feb 21, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zephyr is migrating to hwmv2 and will not be accepting hwmv1 boards or socs after this change, this submission should be converted to hwmv2

@CharlesDias
Copy link
Contributor Author

Zephyr is migrating to hwmv2 and will not be accepting hwmv1 boards or socs after this change, this submission should be converted to hwmv2

Hi, @nordicjm. Do I have to migrate and submit the PR to collab-hwm branch or waiting until collab-hwm goes to upstream?

Thanks.

@nordicjm
Copy link
Collaborator

Zephyr is migrating to hwmv2 and will not be accepting hwmv1 boards or socs after this change, this submission should be converted to hwmv2

Hi, @nordicjm. Do I have to migrate and submit the PR to collab-hwm branch or waiting until collab-hwm goes to upstream?

Thanks.

it would need to be submitted after the completion of the hwmv2 migration, at which point it would be submitted against main

@CharlesDias CharlesDias force-pushed the ministm32h743_board branch 3 times, most recently from 70cf1b2 to bdeada5 Compare February 24, 2024 14:33
@CharlesDias CharlesDias changed the base branch from main to collab-hwm February 24, 2024 17:41
@CharlesDias CharlesDias changed the title boards: arm: Add support for WeAct Studio MiniSTM32H743 Core board hwmv2 boards: arm: Add support for WeAct Studio MiniSTM32H743 Core board Feb 24, 2024
@CharlesDias
Copy link
Contributor Author

Zephyr is migrating to hwmv2 and will not be accepting hwmv1 boards or socs after this change, this submission should be converted to hwmv2

Hi @nordicjm. The PR was updated to hwmv2. Let me know if any other modifications are needed. Thanks.

@CharlesDias CharlesDias force-pushed the ministm32h743_board branch 5 times, most recently from a3ba702 to 3f77fb2 Compare February 25, 2024 19:21
nordicjm
nordicjm reviewed Feb 26, 2024
View reviewed changes
boards/weact/mini_stm32h743/Kconfig.defconfig Outdated
Comment on lines 8 to 9
config BOARD
default "mini_stm32h743"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config BOARD
default "mini_stm32h743"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@nordicjm
Copy link
Collaborator

This will need to be re-targeted to main once hwmv2 is merged, it can then be merged after that point

@nordicjm nordicjm requested a review from erwango February 26, 2024 08:27
@nordicjm nordicjm added the DNM This PR should not be merged (Do Not Merge) label Feb 26, 2024
@CharlesDias CharlesDias force-pushed the ministm32h743_board branch 2 times, most recently from 719d612 to 4368d9f Compare February 26, 2024 17:52
@CharlesDias
Copy link
Contributor Author

Fix color setting.

rect15774

@nordicjm nordicjm added the hwmv2-likely-conflict DNM until collab-hwmv2 has been merged label Feb 27, 2024
@CharlesDias CharlesDias force-pushed the ministm32h743_board branch from a1ee97d to 367d8c3 Compare March 13, 2024 11:40
erwango
erwango requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

samples/subsys/display/lvgl/boards/mini_stm32h743.conf Outdated Show resolved Hide resolved
@CharlesDias CharlesDias force-pushed the ministm32h743_board branch from 367d8c3 to f3c2f9d Compare March 13, 2024 18:53
erwango
erwango previously approved these changes Mar 14, 2024
View reviewed changes
@erwango erwango requested a review from nordicjm March 14, 2024 08:43
@CharlesDias CharlesDias force-pushed the ministm32h743_board branch from f3c2f9d to 468b55f Compare March 14, 2024 11:55
nordicjm
nordicjm requested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it doesn't really seem any different, 83KiB is huge, can you run it through something like https://tinypng.com/ ?

@CharlesDias CharlesDias force-pushed the ministm32h743_board branch from 468b55f to a299140 Compare March 14, 2024 12:11
@CharlesDias
Copy link
Contributor Author

@nordicjm, the final size now is 26.3 kB. Thanks for your tip.

@kartben
Copy link
Collaborator

kartben commented Mar 14, 2024

cwebp -resize 600 0 H448b9a91a90d40649f2254f623c8af96E.webp -o optimized.webp is 31K

@kartben
Copy link
Collaborator

kartben commented Mar 14, 2024

@nordicjm, the final size now is 26.3 kB. Thanks for your tip.

ah! there you go :)

nordicjm
nordicjm previously approved these changes Mar 14, 2024
View reviewed changes
@CharlesDias
Copy link
Contributor Author

The CI failed by timeout! This does make sense?

INFO    - 680/693 qemu_x86_64               tests/modules/thrift/ThriftTest/thrift.ThriftTest.newlib.compactProtocol  FAILED Timeout (qemu 119.707s)
INFO    - /__w/zephyr/zephyr/twister-out/qemu_x86_64/tests/modules/thrift/ThriftTest/thrift.ThriftTest.newlib.compactProtocol/handler.log
ERROR   - SeaBIOS (version zephyr-v1.0.0-0-g31d4e0e-dirty-20200714_234759-fv-az50-zephyr)
Booting from ROM..

erwango
erwango previously approved these changes Mar 14, 2024
View reviewed changes
@CharlesDias
Copy link
Contributor Author

Dear @nordicjm, @erwango, and @kartben,

Do I need to do anything else in this PR?
Thanks.

@erwango
Copy link
Member

erwango commented Mar 25, 2024

@kartben PTAL

kartben
kartben requested changes Mar 26, 2024
View reviewed changes
Copy link
Collaborator

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple minor-ish typos - thanks!

boards/weact/mini_stm32h743/doc/index.rst Outdated Show resolved Hide resolved
boards/weact/mini_stm32h743/doc/index.rst Outdated Show resolved Hide resolved
@CharlesDias
boards: arm: Add support for WeAct Studio MiniSTM32H743 Core board
355d57a 
Adds the device trees, Kconfig, and documentation files.

The following features have been confirmed working on hardware:
* LED
* Button
* ST7735 TFT-LCD
* External QuadSPI NOR Flash memory
* External SPI NOR Flash memory
* USB CDC ACM
* microSD card

Signed-off-by: Charles Dias <[email protected]>
@CharlesDias CharlesDias dismissed stale reviews from erwango and nordicjm via 355d57a March 27, 2024 09:00
@CharlesDias CharlesDias force-pushed the ministm32h743_board branch from a299140 to 355d57a Compare March 27, 2024 09:00
@fabiobaltieri fabiobaltieri merged commit 14015db into zephyrproject-rtos:main Apr 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwango erwango erwango approved these changes

@kartben kartben kartben approved these changes

@nordicjm nordicjm nordicjm left review comments

@lorc lorc Awaiting requested review from lorc

@xakep-amatop xakep-amatop Awaiting requested review from xakep-amatop

@carlocaione carlocaione Awaiting requested review from carlocaione

@povergoing povergoing Awaiting requested review from povergoing

@firscity firscity Awaiting requested review from firscity

@sidcha sidcha Awaiting requested review from sidcha

@Navin-Sankar Navin-Sankar Awaiting requested review from Navin-Sankar

@aaillet aaillet Awaiting requested review from aaillet

@ABOSTM ABOSTM Awaiting requested review from ABOSTM

@FRASTM FRASTM Awaiting requested review from FRASTM

@avisconti avisconti Awaiting requested review from avisconti

@manuargue manuargue Awaiting requested review from manuargue

@nandojve nandojve Awaiting requested review from nandojve

@parthitce parthitce Awaiting requested review from parthitce

@yonsch yonsch Awaiting requested review from yonsch

@fkokosinski fkokosinski Awaiting requested review from fkokosinski

@kgugala kgugala Awaiting requested review from kgugala

@ioannisg ioannisg Awaiting requested review from ioannisg

@stephanosio stephanosio Awaiting requested review from stephanosio

@ibirnbaum ibirnbaum Awaiting requested review from ibirnbaum

@rerickson1 rerickson1 Awaiting requested review from rerickson1

@ssekar15 ssekar15 Awaiting requested review from ssekar15

@carlescufi carlescufi Awaiting requested review from carlescufi

@MulinChao MulinChao Awaiting requested review from MulinChao

@ChiHuaL ChiHuaL Awaiting requested review from ChiHuaL

@Mani-Sadhasivam Mani-Sadhasivam Awaiting requested review from Mani-Sadhasivam

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@dleach02 dleach02 Awaiting requested review from dleach02

@simonguinot simonguinot Awaiting requested review from simonguinot

@jackrosenthal jackrosenthal Awaiting requested review from jackrosenthal

@ifyall ifyall Awaiting requested review from ifyall

@npal-cy npal-cy Awaiting requested review from npal-cy

@vanti vanti Awaiting requested review from vanti

@greg-leach greg-leach Awaiting requested review from greg-leach

@LingaoM LingaoM Awaiting requested review from LingaoM

@soburi soburi Awaiting requested review from soburi

Assignees

@kartben kartben

Labels
area: Display area: Samples Samples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CharlesDias @nordicjm @kartben @erwango @fabiobaltieri @zephyrbot