-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwmv2: Port NXP RT Family #69264
hwmv2: Port NXP RT Family #69264
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor nits.
Please check compliance.
As pointed out by @nordicjm then please consider if using board variant for "hyperflash" and "qspi" isn't more correct.
With hwmv2 we now support a more gerenal variant term.
I did consider and try using variants but found revisions was easier to implement and in my opinion made more sense. The only issue is that there is no such thing as multidimensional revions. Such as, revision A and B, and revision hyperflash and qspi. My response to Jamie above:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor proposal, not blocking for a 👍
I can accept this as a valid reason for choosing board revision over variants. But you still need to address comments like these: I suggest you try it once more, cause the proposed pattern has worked for any other board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor nit.
@decsny it looks like some of the RT1170 EVKB board files were missed in the rename:
|
soc/nxp/imxrt/Kconfig.defconfig
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block
if FLASH_MCUX_FLEXSPI_XIP
# Avoid RWW hazards by defaulting logging to disabled
choice FLASH_LOG_LEVEL_CHOICE
default FLASH_LOG_LEVEL_OFF
endchoice
choice MEMC_LOG_LEVEL_CHOICE
default MEMC_LOG_LEVEL_OFF
endchoice
endif
Currently depends on SOC_SERIES_IMXRT10XX || SOC_SERIES_IMXRT11XX
. It should only depend on SOC_FAMILY_NXP_IMXRT
, this setting needs to be applied for all IMXRT SOCs
Port IMXRT family to HWMV2, including series: - RT11XX - RT10XX - RT6XX Not including RT5XX Co-authored-by: Declan Snyder <[email protected]> Co-authored-by: Daniel DeGrasse <[email protected]> Co-authored-by: Mahesh Mahadevan <[email protected]> Co-authored-by: David Leach <[email protected]> Co-authored-by: Yves Vandervennet <[email protected]> Co-authored-by: Emilio Benavente <[email protected]> Signed-off-by: Declan Snyder <[email protected]>
Convert IMXRT boards except RT595 Co-authored-by: Declan Snyder <[email protected]> Co-authored-by: Daniel DeGrasse <[email protected]> Signed-off-by: Declan Snyder <[email protected]>
Instruction not getting compiled since zephyrproject-rtos#69264. Signed-off-by: Luis Ubieda <[email protected]>
No description provided.