drivers: wifi: esp_at: escape SSID and PSK #69223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukkar
previously approved these changes
Feb 20, 2024
mniestroj
force-pushed
the
wifi-esp-at-escape-ssid-and-psk
branch
from
944b2bf to
51ccf22
Compare
According to [1], SSID and PSK need to be escaped: Escape character syntax is needed if SSID or password contains any special characters, such as , or " or \ Implement character escaping to fix connection attempt to WiFi APs containing special characters as part of SSID, like "My_2,4GHz_AP". Increase "connect command" buffer length to handle worst-case scenario of all the SSID and PSK characters being special characters. [1] https://docs.espressif.com/projects/esp-at/en/release-v2.4.0.0/esp32/AT_Command_Set/Wi-Fi_AT_Commands.html#id6 Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
wifi-esp-at-escape-ssid-and-psk
branch
from
51ccf22 to
20d5357
Compare
rlubos
previously approved these changes
Feb 21, 2024
SSIDs can contains commas (,) when receiving scan results (+CWLAP) or status (+CWJAP) over AT command from ESP-AT chip. This is in conflict with modem subsystem argument parsing, which separates arguments automatically whenever comma is encountered. Use a direct modem command parsing, so that commas within quoted strings are taken into account to be part of that string, instead of being treated as delimiter. This solves `wifi scan` and `wifi status` Zephyr shell commands output, for networks containing commas (like "My_2,4GHz_AP") as part of SSID. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
wifi-esp-at-escape-ssid-and-psk
branch
from
20d5357 to
fa670ba
Compare
rlubos
approved these changes
Feb 28, 2024
jukkar
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to [1], SSID and PSK need to be escaped:
Escape character syntax is needed if SSID or password contains any
special characters, such as
,or"or\Implement character escaping to fix connection attempt to WiFi APs
containing special characters as part of SSID, like "My_2,4GHz_AP".
Increase "connect command" buffer length to handle worst-case scenario of
all the SSID and PSK characters being special characters.
[1] https://docs.espressif.com/projects/esp-at/en/release-v2.4.0.0/esp32/AT_Command_Set/Wi-Fi_AT_Commands.html#id6
Fixes: #69222