Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: release-notes-3.6: Update release notes for NXP additions #69100

Merged
merged 1 commit into from
Feb 17, 2024
Merged

doc: release-notes-3.6: Update release notes for NXP additions #69100

merged 1 commit into from
Feb 17, 2024

Conversation

mmahadevan108
Copy link
Collaborator

NXP additions for 3.6 release

Comment on lines 386 to 389
* Added a driver for NXP ENET which is a rework of the old ``eth_mcux.c`` driver which
had become unmaintainable due to fundamental problems with the lack of PHY abstraction.
``eth_mcux.c`` and the corresponding compatible ``nxp,kinetis-ethernet`` will be deprecated
and this new driver will be supported instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably deserves a mention in the migration guide

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@decsny will work to add it to the migration guide.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmahadevan108, this line item needs "EXPERIMENTAL" as this driver is still in experimental state.

@MaureenHelm, if the driver is experimental, would we put something in the migration guide to highlight how to use it?

Copy link
Member

@henrikbrixandersen henrikbrixandersen Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration guide is only for instructions needed for migrating. I'd put experimental drivers in the release notes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd out experimental drivers in the release notes.

Not sure what you are saying...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, meant to write "put", not "out".

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a mention that this driver is experimental.

Comment on lines 168 to 169
* NXP: Enabled :ref:`linkserver<linkserver-debug-host-tools>` to be the default runner,
if none was set in the board's ``board.cmake`` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't linkserver become the default runner on all supported boards?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was made the default for west command in this release.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That needs to go in the migration guide then.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved this portion to the migration guide.

dleach02
dleach02 previously approved these changes Feb 16, 2024
@@ -19,6 +19,8 @@ Boards

* The deprecated Nordic SoC Kconfig option ``NRF_STORE_REBOOT_TYPE_GPREGRET`` has been removed,
applications that use this should switch to using the :ref:`boot_mode_api` instead.
* NXP: Enabled :ref:`linkserver<linkserver-debug-host-tools>` to be the default runner,
if none was set in the board's ``board.cmake`` file.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the last part. The linkserver was made the default no matter what was set before?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewording but this was set as the default only on NXP boards and not all of them yet. Still a work in progress. Will be clarifying the language here.

Copy link
Member

@decsny decsny Feb 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think brix is pointing out that currently the line here says "if the board did not have a default runner, we set it to linkserver", and that does not reflect the reality which is actually "we set many nxp boards to default runner linkserver regardless of whether they already had a default"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a copy paste from the commit. I have updated the description with more information.

NXP additions for 3.6 release

Signed-off-by: Mahesh Mahadevan <[email protected]>
@henrikbrixandersen henrikbrixandersen merged commit 1368615 into zephyrproject-rtos:main Feb 17, 2024
15 checks passed
@mmahadevan108 mmahadevan108 deleted the Update_Release_Notes branch March 14, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Documentation Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants