Bluetooth: BAP: UC: Fix call to bt_gatt_get_mtu in notify #69080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the unicast_client_ep_notify we would always call bt_gatt_get_mtu, regardless of whether data == NULL. When there is a disconnection, the notify callbacks are called with data == NULL to indicate a unsubscription. In the case of the unicast client, this would also trigger calls to bt_gatt_get_mtu when there is a disconnect, which in turn would trigger a warning that ATT is not connected. Postponing the call to bt_gatt_get_mtu fixes this. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
added
bug
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
pin-zephyr and
sjanc
jhedberg
approved these changes
Feb 16, 2024
kruithofa
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the unicast_client_ep_notify we would always call bt_gatt_get_mtu, regardless of whether data == NULL.
When there is a disconnection, the notify callbacks are called with data == NULL to indicate a unsubscription. In the case of the unicast client, this would also trigger calls to bt_gatt_get_mtu when there is a disconnect, which in turn would trigger a warning that ATT is not connected.
Postponing the call to bt_gatt_get_mtu fixes this.