Bluetooth: BAP: Shell: BA fix add_pa_sync command #69044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The command would attempt to parse the BASE and enter the subgroup information in a NULL pointer. The BASE copy was also done incorrectly, as it did not properly take the UUID into account (which should be moved to a helper function if we expect users to do this). Signed-off-by: Emil Gydesen <[email protected]>
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
pin-zephyr and
sjanc
kruithofa
approved these changes
Feb 16, 2024
cvinayak
approved these changes
Feb 26, 2024
|
@Thalley Is this labelled bug because it is one? Should it be backported to the 3.6 branch? |
It does fix a bug, but it was not a reported bug, so I don't think the severity of this is high enough to warrant a backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command would attempt to parse the BASE and enter the subgroup information in a NULL pointer.
The BASE copy was also done incorrectly, as it did not properly take the UUID into account (which should be moved to a helper function if we expect users to do this).