Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: dai: add driver for NXP's ESAI #68875

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

@zephyrbot
Copy link
Collaborator

zephyrbot commented Feb 12, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@874ed3b zephyrproject-rtos/hal_nxp@6b252c3 (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@LaurentiuM1234
Copy link
Collaborator Author

All zephyr dependencies merged, removing from draft.

@LaurentiuM1234 LaurentiuM1234 marked this pull request as ready for review March 14, 2024 09:14
@LaurentiuM1234 LaurentiuM1234 changed the title drivers: add: add driver for NXP's ESAI drivers: dai: add driver for NXP's ESAI Mar 14, 2024
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding area: Xtensa Xtensa Architecture area: DAI platform: NXP Drivers NXP Semiconductors, drivers labels Mar 14, 2024
@dbaluta
Copy link
Collaborator

dbaluta commented Mar 18, 2024

This is good to go once we fix the trivial compliance check.

drivers/dai/nxp/esai/esai.h Outdated Show resolved Hide resolved
drivers/dai/nxp/esai/esai.h Outdated Show resolved Hide resolved
drivers/dai/nxp/esai/esai.h Show resolved Hide resolved
drivers/dai/nxp/esai/esai.h Outdated Show resolved Hide resolved
drivers/dai/nxp/esai/esai.c Show resolved Hide resolved
drivers/dai/nxp/esai/esai.c Show resolved Hide resolved
@LaurentiuM1234
Copy link
Collaborator Author

V2 changes

  1. Rebased.
  2. Fixed compliance check failure.
  3. Addressed some of @iuliana-prodan's comments.

iuliana-prodan
iuliana-prodan previously approved these changes Mar 28, 2024
@dbaluta
Copy link
Collaborator

dbaluta commented Apr 1, 2024

@LaurentiuM1234 PR looks good to me. Will work with @dleach02 to have this merged first:

zephyrproject-rtos/hal_nxp#338

@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Apr 2, 2024
@LaurentiuM1234
Copy link
Collaborator Author

Dependency merged and CI's green. Should be good to go at this point.

dleach02
dleach02 previously approved these changes Apr 2, 2024
Update hal_nxp reivison to pull in the following patches:

 * mcux: hal_nxp: include HAL ESAI driver if Zephyr ESAI driver
 is enabled

Signed-off-by: Laurentiu Mihalcea <[email protected]>
This commit introduces a new DAI driver used for NXP's ESAI IP.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
Add node for NXP's i.MX8QM/i.MX8QXP AUDIO ESAI0 IP.

Signed-off-by: Laurentiu Mihalcea <[email protected]>
@LaurentiuM1234
Copy link
Collaborator Author

Rebased.

@dbaluta dbaluta assigned dbaluta and unassigned kv2019i Apr 3, 2024
@fabiobaltieri fabiobaltieri merged commit bba8641 into zephyrproject-rtos:main Apr 3, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: DAI area: Devicetree Binding PR modifies or adds a Device Tree binding area: Xtensa Xtensa Architecture manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants