Samples: Bluetooth: Minor changes to improve the user experience #68870
Conversation
zephyrbot
requested review from
asbjornsabo,
hermabe,
jhedberg,
kartben,
nashif,
sjanc,
Thalley and
Vudentz
| @@ -1,11 +1,3 @@ | |||
| CONFIG_BT=y | |||
| CONFIG_LOG=y | |||
| CONFIG_BT_ISO_CENTRAL=y | |||
| CONFIG_BT_SMP=y | |||
There was a problem hiding this comment.
We could consider adding a note to the readme on how to encrypt data.
There was a problem hiding this comment.
Indeed. The sample uses
#if defined(CONFIG_BT_SMP)
iso_chan.required_sec_level = BT_SECURITY_L2,
#endif /* CONFIG_BT_SMP */So that if SMP is enabled, it automatically encrypts the CIS
| @@ -1,11 +1,3 @@ | |||
| CONFIG_BT=y | |||
| CONFIG_LOG=y | |||
| CONFIG_BT_ISO_CENTRAL=y | |||
| CONFIG_BT_SMP=y | |||
There was a problem hiding this comment.
Indeed. The sample uses
#if defined(CONFIG_BT_SMP)
iso_chan.required_sec_level = BT_SECURITY_L2,
#endif /* CONFIG_BT_SMP */So that if SMP is enabled, it automatically encrypts the CIS
rugeGerritsen
force-pushed
the
improve_bt_sample_user_experience
branch
from
3351812 to
5afe7b2
Compare
| @@ -35,7 +35,7 @@ static void device_found(const bt_addr_le_t *addr, int8_t rssi, uint8_t type, | |||
| } | |||
|
|
|||
| /* connect only to devices in close proximity */ | |||
| if (rssi < -70) { | |||
| if (rssi < -50) { | |||
There was a problem hiding this comment.
There are some bsim tests failing because of changes similar to this. I'm looking into finding where this can be changed
|
@rugeGerritsen Looks like the RSSI change is failing some of the BSIM tests, as they get |
Let me know if you know where this comes from. Otherwise I can change the limit to -60 dBm |
@aescolar might know |
|
@rugeGerritsen Meaning, with |
Thanks for the answer. I assumed it was something along those lines. Should I apply this to all bsim tests or would you rather like to keep it as is? |
I'd do it just to the ones that are affected by this PR samples changes. |
When the Bluetooth central samples in an open air environment it is very likely that there are multiple devices nearby with a received signal strength stronger than -70 dBm. To avoid connecting to the wrong device, make the check stricter. For tests using those samples, the NtNcable attenuation is changed from the default 60 dBm to 40 dBm to satisfy the new requirement. Signed-off-by: Rubin Gerritsen <[email protected]>
Some SoCs in the nRF52 series do not support encrypting and decrypting isochronous channels packets. To make it easier to get started with the central_iso sample, we want to turn of SMP by default. Without this config, the sample still serves its purpose. Encrypting the isochronous channel is as simple as enabling BT_SMP. Signed-off-by: Rubin Gerritsen <[email protected]>
Extend the sample documentation for the central and peripheral iso samples so that they become easier to get started with. Signed-off-by: Rubin Gerritsen <[email protected]>
rugeGerritsen
force-pushed
the
improve_bt_sample_user_experience
branch
from
5afe7b2 to
f711cd7
Compare
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
carlescufi,
cvinayak,
kruithofa,
mtpr-ot and
thoh-ot
|
@jhedberg should these go for 3.6? Samples are kindof documentation imo |
I think it's a little late in the release cycle for non-critical changes like this. I'd suggest aiming for v3.7.0. |
I'm fine waiting until 3.7. |
…below -50 When the Bluetooth central samples in an open air environment it is very likely that there are multiple devices nearby with a received signal strength stronger than -70 dBm. To avoid connecting to the wrong device, make the check stricter. For tests using those samples, the NtNcable attenuation is changed from the default 60 dBm to 40 dBm to satisfy the new requirement. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
…SMP=y Some SoCs in the nRF52 series do not support encrypting and decrypting isochronous channels packets. To make it easier to get started with the central_iso sample, we want to turn of SMP by default. Without this config, the sample still serves its purpose. Encrypting the isochronous channel is as simple as enabling BT_SMP. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
Extend the sample documentation for the central and peripheral iso samples so that they become easier to get started with. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
…below -50 When the Bluetooth central samples in an open air environment it is very likely that there are multiple devices nearby with a received signal strength stronger than -70 dBm. To avoid connecting to the wrong device, make the check stricter. For tests using those samples, the NtNcable attenuation is changed from the default 60 dBm to 40 dBm to satisfy the new requirement. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
…SMP=y Some SoCs in the nRF52 series do not support encrypting and decrypting isochronous channels packets. To make it easier to get started with the central_iso sample, we want to turn of SMP by default. Without this config, the sample still serves its purpose. Encrypting the isochronous channel is as simple as enabling BT_SMP. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
Extend the sample documentation for the central and peripheral iso samples so that they become easier to get started with. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]>
…below -50 When the Bluetooth central samples in an open air environment it is very likely that there are multiple devices nearby with a received signal strength stronger than -70 dBm. To avoid connecting to the wrong device, make the check stricter. For tests using those samples, the NtNcable attenuation is changed from the default 60 dBm to 40 dBm to satisfy the new requirement. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit 2c8d14a)
…SMP=y Some SoCs in the nRF52 series do not support encrypting and decrypting isochronous channels packets. To make it easier to get started with the central_iso sample, we want to turn of SMP by default. Without this config, the sample still serves its purpose. Encrypting the isochronous channel is as simple as enabling BT_SMP. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit b1980ed)
Extend the sample documentation for the central and peripheral iso samples so that they become easier to get started with. Upstream PR: zephyrproject-rtos/zephyr#68870 Signed-off-by: Rubin Gerritsen <[email protected]> (cherry picked from commit eb59f8d)
This PR contains some minor changes which make it easier to get started with some of the Bluetooth samples.