uart_native_tty: Emulate an interrupt driven uart #68857
Conversation
zephyrbot
added
area: UART
zagor
force-pushed
the
native-tty-emulate-irq
branch
from
4ccdbdd to
052072e
Compare
Emulate SERIAL_SUPPORT_INTERRUPT for UART_NATIVE_TTY, using a thread that polls the tty and invokes the callback. This allows interrupt-driven subsystems such as modbus to use a native tty, which is useful for testing purposes. Signed-off-by: Björn Stenberg <[email protected]>
zagor
force-pushed
the
native-tty-emulate-irq
branch
from
052072e to
64ea668
Compare
|
Rebased and updated this thread-based patch. My schedule filled up faster than I hoped. I propose merging this as a first step and come back at a later time with an event-based version. |
|
Thanks @zagor
That is fair, the other proposal is certainly much more work. I will do another review pass to this one. |
| This driver only supports poll mode and interrupt mode. Async mode is not | ||
| supported. |
There was a problem hiding this comment.
I think the first paragraph of this section now also requires updating. It currently says "With this driver an application can use the polling UART API (uart_poll_out, uart_poll_in) to write and read characters to and from a connected serial port device."
cc @aescolar
There was a problem hiding this comment.
BTW, would it make sense / be possible to have the same approach for the uart_native_pty driver?
There was a problem hiding this comment.
@kartben Sure, I guess nobody though it worthwhile so far
| } else { | ||
| k_sleep(K_MSEC(1)); | ||
| } | ||
| } else if (data->tx_irq_enabled) { |
There was a problem hiding this comment.
Is it possible that this should be an 'if' instead of an 'else if'? rx_irq_enabled is only set false while reading the receive buffer, so data could never be transmitted in my case.
There was a problem hiding this comment.
It seems like a bug. @ct-fk Would you like to send a PR with the fix?
Emulate SERIAL_SUPPORT_INTERRUPT for UART_NATIVE_TTY, using a thread that
polls the tty and invokes the callback.
This allows interrupt-driven subsystems such as modbus to use a native tty,
which is useful for testing purposes.