Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hwmv2: boards: Add bl654_dvk pa variant #68842

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

jatedev
Copy link
Contributor

@jatedev jatedev commented Feb 11, 2024

Add defconfig, dts, yaml for bl654_dvk_bl654pa. They are largely the same as bl654_dvk
Add Kconfig support for bl654_dvk_bl654pa.
Add samples/bluetooth/hci_uart support for this config at 1 MHz with power amplifier
Add docs

@zephyrbot zephyrbot added area: ADC Analog-to-Digital Converter (ADC) area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) platform: Laird Connectivity Laird Connectivity area: Samples Samples labels Feb 11, 2024
Copy link

Hello @jatedev, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

Copy link
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hwmv1 is obsolete and being transitioned to hwmv2 with the aim of it being merged right after the 3.6 release is complete, this should be done as hwmv2

@rerickson1
Copy link
Member

@ahedin25 could would like your review here.

@rerickson1 rerickson1 requested review from nordicjm and tejlmand March 5, 2024 18:00
@rerickson1 rerickson1 added the DNM This PR should not be merged (Do Not Merge) label Mar 5, 2024
@rerickson1
Copy link
Member

Add DNM. We are discussing internally.

nordicjm
nordicjm previously approved these changes Mar 6, 2024
@rerickson1 rerickson1 removed the DNM This PR should not be merged (Do Not Merge) label Mar 12, 2024
@jatedev jatedev force-pushed the bl654_dvk_bl654pa branch from 2fe245c to da77c9f Compare March 21, 2024 03:24
rerickson1
rerickson1 previously approved these changes Mar 22, 2024
@rerickson1 rerickson1 requested a review from nordicjm March 22, 2024 22:07
rx-gain-db = <11>;
};
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you will now need to copy bl654_dvk_defconfig to bl654_dvk_nrf52840_pa_defconfig as the common config feature is in the process of being reverted

Add pa variant definition to board.yml
Add bl654_dvk_nrf52840_pa files dts, yaml, defconfig
Update doc with information on variant and regulatory information

Signed-off-by: Jate Sujjavanich <[email protected]>
@fabiobaltieri fabiobaltieri merged commit c50843a into zephyrproject-rtos:main Apr 3, 2024
21 checks passed
Copy link

github-actions bot commented Apr 3, 2024

Hi @jatedev!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ADC Analog-to-Digital Converter (ADC) area: Samples Samples platform: Laird Connectivity Laird Connectivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants