Bluetooth: BAP: Shell: Minor refactor of LC3 encoder #68810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra,
pin-zephyr and
sjanc
This commit renames a few variables and changes the type and adds some additional checks. It moves stream specific data to the shell stream struct, but still keeps the global values that were used to initialize the LC3 encoder The purpose of this is to better allow for a future LC3 decoder without any clashes in names or the like. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
bap_shell_lc3_cleanup
branch
from
2c58152 to
f83add6
Compare
kruithofa
reviewed
Feb 14, 2024
| return false; | ||
| } | ||
|
|
||
| err = bt_bap_ep_get_info(bap_stream->ep, &info); | ||
| if (err != 0) { | ||
| bap_stream = &sh_stream->stream.bap_stream; |
There was a problem hiding this comment.
We are guaranteed that bap_stream is non-NULL since the unicast_stream gets initialised in the function cmd_init and so we do not need to check for NULL.
Is that correct?
There was a problem hiding this comment.
No: We are guaranteed that bap_stream is non NULL because it's the address of a field :) (Notice the &)
kruithofa
approved these changes
Feb 14, 2024
jhedberg
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit renames a few variables and changes the type and adds some additional checks.
It moves stream specific data to the shell stream
struct, but still keeps the global values that were used to initialize the LC3 encoder
The purpose of this is to better allow for a future LC3 decoder without any clashes in names or the like.