Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example in sparkfun,serlcd.yaml #68783

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

cperkulator
Copy link
Contributor

fix documentation to include -ms

@cperkulator cperkulator requested a review from thedjnK as a code owner February 8, 2024 22:59
@zephyrbot zephyrbot added area: Aux display area: Devicetree Binding PR modifies or adds a Device Tree binding labels Feb 8, 2024
@zephyrbot zephyrbot requested review from galak and xingrz February 8, 2024 22:59
@thedjnK thedjnK assigned thedjnK and unassigned galak Feb 8, 2024
Copy link
Collaborator

@thedjnK thedjnK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs commit message and correct sign off line with valid email, commit title must be correctly formatted too, see https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines for details

@thedjnK thedjnK added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Feb 8, 2024
@thedjnK thedjnK added this to the v3.6.0 milestone Feb 8, 2024
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the compliance check failure needs to be addressed before this can be merged.

@henrikbrixandersen henrikbrixandersen changed the title Update sparkfun,serlcd.yaml Fix example in sparkfun,serlcd.yaml Feb 10, 2024
@henrikbrixandersen henrikbrixandersen removed this from the v3.6.0 milestone Feb 19, 2024
@henrikbrixandersen
Copy link
Member

@cperkulator Any plans to fix the compliance failure?

@thedjnK
Copy link
Collaborator

thedjnK commented Apr 9, 2024

ping @cperkulator

@cperkulator
Copy link
Contributor Author

just pushed, hopefully that works. sorry about that!

@thedjnK
Copy link
Collaborator

thedjnK commented Apr 10, 2024

@cperkulator there is an issue with the email sign off in the commit message

yaml file did not match device tree bindings.

Signed-off-by: Caleb Perkinson <[email protected]>
@cperkulator
Copy link
Contributor Author

@thedjnK looks like this is all passing now. sorry for all the hassle

@henrikbrixandersen henrikbrixandersen merged commit 2fc4205 into zephyrproject-rtos:main Apr 14, 2024
21 checks passed
@cperkulator cperkulator deleted the fix-serlcd branch April 15, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Aux display area: Devicetree Binding PR modifies or adds a Device Tree binding Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants