-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix example in sparkfun,serlcd.yaml #68783
Fix example in sparkfun,serlcd.yaml #68783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs commit message and correct sign off line with valid email, commit title must be correctly formatted too, see https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines for details
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but the compliance check failure needs to be addressed before this can be merged.
@cperkulator Any plans to fix the compliance failure? |
ping @cperkulator |
just pushed, hopefully that works. sorry about that! |
@cperkulator there is an issue with the email sign off in the commit message |
yaml file did not match device tree bindings. Signed-off-by: Caleb Perkinson <[email protected]>
@thedjnK looks like this is all passing now. sorry for all the hassle |
fix documentation to include
-ms