Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dts: bindings: can: remove deprecated properties for initial timing #68714

Conversation

henrikbrixandersen
Copy link
Member

Remove the deprecated properties for setting the initial timing parameters of a CAN controller.

@henrikbrixandersen henrikbrixandersen added area: CAN Release Notes Required Release notes required for this change labels Feb 7, 2024
@henrikbrixandersen henrikbrixandersen added this to the v3.7.0 milestone Feb 7, 2024
@henrikbrixandersen henrikbrixandersen self-assigned this Feb 7, 2024
@henrikbrixandersen henrikbrixandersen force-pushed the can_remove_deprecated_dts_properties branch from 47c8429 to 68c2f11 Compare February 26, 2024 08:46
@henrikbrixandersen henrikbrixandersen added Release Notes To be mentioned in the release notes and removed Release Notes Required Release notes required for this change labels Feb 26, 2024
@henrikbrixandersen henrikbrixandersen marked this pull request as ready for review February 26, 2024 08:50
@zephyrbot zephyrbot added area: Devicetree Binding PR modifies or adds a Device Tree binding platform: NXP S32 NXP Semiconductors, S32 platform: STM32 ST Micro STM32 platform: Renesas R-Car Renesas R-Car platform: NXP Drivers NXP Semiconductors, drivers platform: Infineon Infineon Technologies AG labels Feb 26, 2024
@@ -45,6 +45,19 @@ Bluetooth HCI
Controller Area Network (CAN)
=============================

* Removed the following deprecated CAN controller devicetree properties. Out-of-tree boards using
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a link to can-controller DTS binding?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no common binding for CAN controllers, just a base binding included by all CAN controller DTS bindings.

Remove the deprecated properties for setting the initial timing parameters
of a CAN controller.

Signed-off-by: Henrik Brix Andersen <[email protected]>
Mention removal of deprecated CAN controller devicetree properties.

Signed-off-by: Henrik Brix Andersen <[email protected]>
@henrikbrixandersen henrikbrixandersen force-pushed the can_remove_deprecated_dts_properties branch from 68c2f11 to 8ba8321 Compare February 26, 2024 12:19
Copy link
Member

@manuargue manuargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for NXP drivers

@henrikbrixandersen
Copy link
Member Author

Reviews are welcome. I have other work depending on removing support for these deprecated properties.

@aescolar aescolar merged commit ff61a38 into zephyrproject-rtos:main Mar 1, 2024
21 checks passed
@henrikbrixandersen henrikbrixandersen deleted the can_remove_deprecated_dts_properties branch March 1, 2024 08:13
Comment on lines +54 to +55
* ``phase-seg1``
* ``phase-seg1``
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@henrikbrixandersen fyi I will be fixing the two "seg1 instead of seg2" typos in a global migration guide / release notes cleanup PR later today

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CAN area: Devicetree Binding PR modifies or adds a Device Tree binding platform: Infineon Infineon Technologies AG platform: NXP Drivers NXP Semiconductors, drivers platform: NXP S32 NXP Semiconductors, S32 platform: Renesas R-Car Renesas R-Car platform: STM32 ST Micro STM32 Release Notes To be mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants