Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: stop relying on filters to determine non-secure execution #68691

Closed

Conversation

nashif
Copy link
Member

@nashif nashif commented Feb 7, 2024

Instead of relying on filters, use the supported keyword and
execute/build tests faster.

Signed-off-by: Anas Nashif [email protected]

@erwango
Copy link
Member

erwango commented Feb 7, 2024

Will we get those changes when collab-hwm branch will be merged in main ? (ie do you think that rebase will work ?).
Otherwise it may better to wait V3.7.0 opening (post collab-hwm merge) for such PRs

@nashif
Copy link
Member Author

nashif commented Feb 7, 2024

Will we get those changes when collab-hwm branch will be merged in main ? (ie do you think that rebase will work ?).
Otherwise it may better to wait V3.7.0 opening (post collab-hwm merge) for such PRs

someone needs to figure this out tbh and get the rebase right, we can't block changes like this just because someone is working on a branch somewhere. This probably can wait, but our CI costs keep skyrocketing and we need to figure this out one way or ther other...

nashif added 2 commits March 11, 2024 13:09
Instead of relying on filters, use the supported keyword and
execute/build tests faster.

Signed-off-by: Anas Nashif <[email protected]>
_ns is usuaully a variant of another board, so ignore many tests that
will be covered by the main board definition. Leave just the qemu _ns
variants with full coverage.

Signed-off-by: Anas Nashif <[email protected]>
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label May 11, 2024
@nashif nashif removed the Stale label May 11, 2024
Copy link
Collaborator

@ithinuel ithinuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit: the tag used for tf-m is trusted-firmware-m, so we may want to use something along trusted-firmware-m-non-secure but that's a bit verbose.

cc @d3zd3z

Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Aug 17, 2024
@github-actions github-actions bot closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants