-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: stop relying on filters to determine non-secure execution #68691
Conversation
ccafe3f
to
bdf2fdb
Compare
Will we get those changes when collab-hwm branch will be merged in main ? (ie do you think that rebase will work ?). |
someone needs to figure this out tbh and get the rebase right, we can't block changes like this just because someone is working on a branch somewhere. This probably can wait, but our CI costs keep skyrocketing and we need to figure this out one way or ther other... |
Instead of relying on filters, use the supported keyword and execute/build tests faster. Signed-off-by: Anas Nashif <[email protected]>
_ns is usuaully a variant of another board, so ignore many tests that will be covered by the main board definition. Leave just the qemu _ns variants with full coverage. Signed-off-by: Anas Nashif <[email protected]>
bdf2fdb
to
060c2c3
Compare
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nit: the tag used for tf-m is trusted-firmware-m, so we may want to use something along trusted-firmware-m-non-secure
but that's a bit verbose.
cc @d3zd3z
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Instead of relying on filters, use the supported keyword and
execute/build tests faster.
Signed-off-by: Anas Nashif [email protected]