Bluetooth: Audio: redone the base subgroup struct. #68676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
7 times, most recently
from
ebcba12 to
576fb09
Compare
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
hermabe,
jhedberg,
kartben,
kruithofa,
larsgk,
MariuszSkamra,
nashif,
sjanc,
Thalley and
Vudentz
Thalley
requested changes
Feb 8, 2024
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
from
576fb09 to
e7216ea
Compare
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
from
e7216ea to
32ddebf
Compare
Thalley
requested changes
Feb 9, 2024
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
from
32ddebf to
5672ff8
Compare
Thalley
requested changes
Feb 9, 2024
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
from
5672ff8 to
9144149
Compare
Thalley
requested changes
Feb 14, 2024
The Broadcast Assistant API should be fully independent of the scan delegator. Therefore the new struct bt_bap_bass_subgroup has been defined to avoid a dependency. Fixes: zephyrproject-rtos#68338 Signed-off-by: Ping Wang <[email protected]>
pin-zephyr
force-pushed
the
le_audio_bug_fix
branch
from
9144149 to
0ebded6
Compare
Thalley
approved these changes
Feb 14, 2024
fredrikdanebjer
approved these changes
Feb 14, 2024
|
@Thalley Is this bug fix targeting v3.6.0? If so, please add it to the milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The struct bt_bap_broadcast_assistant_add_src_param and struct bt_bap_broadcast_assistant_mod_src_param use the struct bt_bap_scan_delegator_subgroup to provide subgroup information to the scan delegator.
The issue is that the struct bt_bap_scan_delegator_subgroup depend on a Kconfig value that only exists for the Scan Delegator (guarded by CONFIG_BT_BAP_SCAN_DELEGATOR).
Therefore, make a general struct bt_bap_base_subgroup which can be used by scan delegator and broadcast assistant.
Fixes #68338