-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing tests alignments for nrf54l15 #68618
Add missing tests alignments for nrf54l15 #68618
Conversation
"Unexpected result %" PRId64 " (expected: %" PRId64 ")", ticks, exp_ticks); | ||
} | ||
|
||
void test_main(void) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to convert it to the new ztest API.
820b180
to
405e2cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs converting to hwmv2
@magp-nordic can you please rebase this PR? (The hwmv2 branch has been merged now) |
405e2cb
to
4601033
Compare
Add NRF GRTC timer test for nRF54L15. Signed-off-by: Magdalena Pastula <[email protected]>
4601033
to
0434f3d
Compare
Rebased, should also be aligned with hwmv2. |
instance: | ||
type: string | ||
required: true | ||
description: | | ||
The TIMER instance id as used in the MDK and documentation. For example for TIMER2: | ||
|
||
instance = "2"; | ||
|
||
And for TIMER00: | ||
|
||
instance = "00"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have previously rejected similar work-arounds for other SoCs. Could we find another way around this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't nack here, but I agree that this is a DT usage violation we have rejected multiple times. If HALs do not match DT expectations, they should be modified to do so, use other layers (eg nrf_
), or not use them at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@henrikbrixandersen This change is part of one of the commits fixing #69216 . Here is an alternative fix for the same issue: #69966. If it gets merged, I will drop these changes from my PR.
Add nRF54L15 overlay for counter_basic_api test. Signed-off-by: Magdalena Pastula <[email protected]>
Mark counter as supported for nRF54L15 to allow running counter_basic_api by twister. Signed-off-by: Magdalena Pastula <[email protected]>
0434f3d
to
1550ed8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we only have custom timer driver tests for nRF timers. Wouldn't it possible to have a generic timer test covering the standard Zephyr timer driver API?
@nordic-krch any comments here? |
This PR adds missing GRTC test and counter test alignment for nRF54L15.
Additionally, it contains fix for getting timer's instance number in the counter driver.Fixes #69216Fixed by #69966