Uninitialized scalar variable &temp_data
#68591
Conversation
|
Hello @Nu1l-ptr, and thank you very much for your first pull request to the Zephyr project! |
ghost
requested a review
from
There was a problem hiding this comment.
The commits need to be squashed into one, if you do a git rebase then mark the other 2 as fixup. Also the commit title and message should be formatted as per https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines
|
I think i need to use |
The |
| @@ -266,7 +266,8 @@ static size_t upload_message_header_size(struct img_gr_upload *upload_state) | |||
| } else { | |||
| map_count = 10; | |||
| } | |||
| temp_data = NULL; | |||
|
|
|||
| memset(temp_data, 0, sizeof(temp_data)); | |||
There was a problem hiding this comment.
I don't really know what you are doing? Remove this and change line 258 to:
uint8_t temp_data = 0;
There was a problem hiding this comment.
sorry, I am not too used to git.
|
The commits need to be squashed |
zephyrbot
added
the
Trivial
There was a problem hiding this comment.
Sorry, need to introduce yourself when doing changes:
https://docs.zephyrproject.org/latest/contribute/guidelines.html#signed-off-by
Signed-off-by: nu1lptr <[email protected]>
|
@Nu1l-ptr we need this fix for the upcoming 3.6.0 release. Please fix the issues or we will need to open a parallel Pull Request fixing this. Thanks in advance! Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. |
Superseded by #68974 |
zcbor_map_start_encodefunction is using Uninitialized variable&temp_dataFixes #68636