Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modem: hl7800: sock_read len arg is not used #68582

Conversation

rerickson1
Copy link
Member

The static function sock_read does not need a length arg, remove it.

fixes #58566

@MaureenHelm MaureenHelm added bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix labels Feb 6, 2024
@MaureenHelm MaureenHelm added this to the v3.6.0 milestone Feb 6, 2024
Copy link
Collaborator

@str4t0m str4t0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As len is only assigned once, but never used, maybe even make it more explicit and cast the return value to void?

(void)net_buf_findctrl(*buf, &frag);

I am not sure if Coverity also warns about "assigned but never used".

@str4t0m
Copy link
Collaborator

str4t0m commented Feb 6, 2024

I am going to close issue #67972, as it is an duplicate of the issue #58566 you are referencing. If this differs from the usual handling of duplicates please let me know.

The static function sock_read does not need a length arg, remove it.

Signed-off-by: Ryan Erickson <[email protected]>
@henrikbrixandersen henrikbrixandersen merged commit 34ec42b into zephyrproject-rtos:main Feb 8, 2024
17 checks passed
@rerickson1 rerickson1 deleted the laird/pr/hl7800_sock_read branch February 12, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Modem Drivers bug The issue is a bug, or the PR is fixing a bug Coverity A Coverity detected issue or its fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coverity CID: 215224] Parse warning in drivers/modem/hl7800.c
6 participants