samples/soc_flash_nrf: Fix soc_flash_nrf doc and printfs #68565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-nordic
force-pushed
the
soc-flash-nrf-doc-eh
branch
4 times, most recently
from
cd62a62 to
c073d49
Compare
kartben
requested changes
Feb 13, 2024
de-nordic
force-pushed
the
soc-flash-nrf-doc-eh
branch
from
69619de to
fa7b50a
Compare
kartben
previously approved these changes
Feb 28, 2024
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
The commit fixes soc_flash_nrf sample documentation where incorrect partition names has been used and removes information of CONFIG_TRUSTED_EXECUTION_NONSECURE affecting which partition is used as this is no longer true. The printf message reporting start of sample has been modified to print "Nordic nRF5 Flash Sample" instead of "Nordic nRF5 Flash Testing", which is more accurate for code residing in samples. Signed-off-by: Dominik Ermel <[email protected]>
de-nordic
force-pushed
the
soc-flash-nrf-doc-eh
branch
from
fa7b50a to
37fc673
Compare
|
@kartben please revisit |
ubieda
approved these changes
Aug 1, 2024
kartben
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes soc_flash_nrf sample documentation where incorrect partition names has been used and removes information of CONFIG_TRUSTED_EXECUTION_NONSECURE affecting which partition is used as this is no longer true.
The printf message reporting start of sample has been modified to print "Nordic nRF5 Flash Sample" instead of
"Nordic nRF5 Flash Testing", which is more accurate for code residing in samples.
Samples are for showing how things work, not testing.