Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Controller: Build vendor LLL as library #68499

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Feb 3, 2024

Build vendor LLL as separate library so that independent compiler flags can be supplied if required.

@cvinayak cvinayak force-pushed the github_lll_library branch 4 times, most recently from b7b590e to 2ca6e0c Compare February 5, 2024 10:22
Build vendor LLL as separate library so that independent
compiler flags can be supplied if required.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 5, 2024

@dleach02 as a codeowner of openisa, could you review the changes I have done to CMakelists (the building is covered in CI though) and hope its fine on target.

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

@henrikbrixandersen @MaureenHelm This PR is only refactoring the CMakelists, the builds are covered in the CI, and only need a second approval from @dleach02 as a codeowner of openisa. Can this be included in Zephyr v3.6?

@henrikbrixandersen henrikbrixandersen added this to the v3.6.0 milestone Feb 9, 2024
@cvinayak cvinayak added the DNM This PR should not be merged (Do Not Merge) label Feb 9, 2024
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

Added DNM, until an approval from @dleach02

@henrikbrixandersen
Copy link
Member

@henrikbrixandersen @MaureenHelm This PR is only refactoring the CMakelists, the builds are covered in the CI, and only need a second approval from @dleach02 as a codeowner of openisa. Can this be included in Zephyr v3.6?

Unfortunately, this has not yet been approved. We are a bit too late in the release process (hard freeze is tomorrow) to bring in this kind of refactoring, sorry. I have removed this from the v3.6.0 milestone.

@henrikbrixandersen henrikbrixandersen removed this from the v3.6.0 milestone Feb 15, 2024
@cvinayak cvinayak removed the DNM This PR should not be merged (Do Not Merge) label Feb 22, 2024
@cvinayak cvinayak added this to the v3.7.0 milestone Feb 22, 2024
@aescolar
Copy link
Member

@dleach02, please note your review is gating this PR

@aescolar
Copy link
Member

@cvinayak do you still want to gate this PR merge until @dleach02 's review? or should it just be merged?

@dleach02
Copy link
Member

apologies for not seeing this... HWMv2 distracted me

@dleach02 dleach02 merged commit 7bd2804 into zephyrproject-rtos:main Feb 27, 2024
27 of 28 checks passed
@fabiobaltieri
Copy link
Member

fabiobaltieri commented Feb 29, 2024

hey @cvinayak, I just bisected an issue to this PR, since this my nrf52 devices are getting a random address every time and the log shows:

[00:00:00.477,447] <wrn> bt_id: No static addresses stored in controller                                                               

Is this something you could look into?

Found it: #69721

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants