-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Controller: Build vendor LLL as library #68499
Conversation
b7b590e
to
2ca6e0c
Compare
Build vendor LLL as separate library so that independent compiler flags can be supplied if required. Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
2ca6e0c
to
2de71fa
Compare
@dleach02 as a codeowner of openisa, could you review the changes I have done to CMakelists (the building is covered in CI though) and hope its fine on target. |
@henrikbrixandersen @MaureenHelm This PR is only refactoring the CMakelists, the builds are covered in the CI, and only need a second approval from @dleach02 as a codeowner of openisa. Can this be included in Zephyr v3.6? |
Added DNM, until an approval from @dleach02 |
Unfortunately, this has not yet been approved. We are a bit too late in the release process (hard freeze is tomorrow) to bring in this kind of refactoring, sorry. I have removed this from the v3.6.0 milestone. |
@dleach02, please note your review is gating this PR |
apologies for not seeing this... HWMv2 distracted me |
Build vendor LLL as separate library so that independent compiler flags can be supplied if required.