Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: shell: iface: Add command to set gateway #68465

Merged
merged 1 commit into from
Feb 26, 2024
Merged

net: shell: iface: Add command to set gateway #68465

merged 1 commit into from
Feb 26, 2024

Conversation

MateuszKarlic
Copy link
Contributor

Add a command net iface set_ipv4_gateway that allows setting IPv4 gateway for an interface from net shell.

rlubos
rlubos reviewed Feb 2, 2024
View reviewed changes
Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be a better fit to put this in IPv4 shell space? I. e.:
net ipv4 gateway <index> <address>

@MateuszKarlic
Copy link
Contributor Author

MateuszKarlic commented Feb 2, 2024 •
edited
Loading

I was also thinking about putting it behind ipv4. As suggested, moved it there and added argc check

@MateuszKarlic
net: shell: ipv4: Add command to set gateway
5af8574 
Add a command `net ipv4 gateway` that allows
setting IPv4 gateway for an interface from net shell.

Signed-off-by: Mateusz Karlic <[email protected]>
pdgendt
pdgendt approved these changes Feb 2, 2024
View reviewed changes
Copy link
Collaborator

@pdgendt pdgendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if you have the time to spare, it would be nice to do the same for the netmask.

@jukkar
Copy link
Member

jukkar commented Feb 2, 2024

if you have the time to spare, it would be nice to do the same for the netmask.

Preferably after this change #68419

@MateuszKarlic
Copy link
Contributor Author

MateuszKarlic commented Feb 5, 2024 •
edited
Loading

if you have the time to spare, it would be nice to do the same for the netmask.

Preferably after this change #68419

Sure, I can take a look into it after that mentioned PR is merged

@fabiobaltieri fabiobaltieri added this to the v3.7.0 milestone Feb 6, 2024
@aescolar aescolar merged commit bdd0955 into zephyrproject-rtos:main Feb 26, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlubos rlubos rlubos approved these changes

@pdgendt pdgendt pdgendt approved these changes

@jukkar jukkar jukkar approved these changes

@ssharks ssharks Awaiting requested review from ssharks

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

Assignees

@rlubos rlubos

Labels
area: Networking
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@MateuszKarlic @jukkar @pdgendt @rlubos @fabiobaltieri @zephyrbot @aescolar