Develop/ram console option known addr buf #68452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: Console
area: ARM64
zephyrbot
requested review from
carlocaione,
dcpleung,
nashif,
npitre,
povergoing and
SgrrZhf
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
2 times, most recently
from
cf3e9e0 to
18d8ba5
Compare
|
This update fixed some check failures. |
carlocaione
requested changes
Feb 5, 2024
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
from
18d8ba5 to
8a64dfb
Compare
carlocaione
previously approved these changes
Feb 7, 2024
dleach02
previously approved these changes
Feb 22, 2024
andyross
reviewed
Feb 23, 2024
Zhiqiang-Hou
dismissed stale reviews from dleach02 and carlocaione
via
6c7ea74
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
2 times, most recently
from
6c7ea74 to
7ae1799
Compare
|
Updated to fix LONG_LINE check warning. |
carlocaione
previously approved these changes
Feb 26, 2024
dleach02
approved these changes
Feb 29, 2024
dleach02
approved these changes
Feb 29, 2024
dleach02
requested changes
Feb 29, 2024
Okay, will rebase then. |
kartben
previously requested changes
May 6, 2024
nordicjm
requested changes
May 7, 2024
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
from
84716af to
8671935
Compare
JiafeiPan
previously approved these changes
May 16, 2024
nordicjm
previously approved these changes
May 16, 2024
|
@kartben can you review the changes to your change request |
kartben
dismissed
their stale review
Earlier comments regarding documentation have been addressed
kartben
reviewed
May 22, 2024
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
from
8671935 to
cbf420b
Compare
In arm64 linker script, create a memory region and section for each device tree node with compatible string "zephyr,memory-region". Signed-off-by: Hou Zhiqiang <[email protected]>
It has been added in the arm64 common linker script, so also update the one of mimx9 SoCs. Signed-off-by: Hou Zhiqiang <[email protected]>
Leave one byte from the CONFIG_RAM_CONSOLE_BUFFER_SIZE to ensure the NULL-termination. Signed-off-by: Hou Zhiqiang <[email protected]>
Currently, the ram_console buffer is defined as a global var, its
address is determined during the building and may be changed when
code update. This is not a problem if the ram_console is just used
in debug purpose.
While in the heterogeneous SoCs, there can be multiple MPU Cores
and several MCU cores, it can run multiple OS/bare-metal instances
on these cores, but the UART ports may be not enough, so the
ram_console can be leveraged. To make it easy to use, it's better
make the console buffer fixed and predefined.
This patch adds a option to link the console buffer to a given
section, through the "zephyr,memory-region" device tree node, then
the address can be known from the device tree node and easy to
check from other cores running Linux/U-Boot.
To use this option, the chosen property 'zephyr,ram-console' must
be added, the following is a example:
chosen {
zephyr,ram-console = &ram_console;
};
ram_console: memory@93d00000 {
compatible = "zephyr,memory-region";
reg = <0x93d00000 DT_SIZE_K(4)>;
zephyr,memory-region = "RAM_CONSOLE";
};
Signed-off-by: Hou Zhiqiang <[email protected]>
The ram-console snippet disabled UART console and enabled the RAM console with the option link the RAM console buffer to a dedicate section in a new added memory-region. Signed-off-by: Hou Zhiqiang <[email protected]>
Zhiqiang-Hou
force-pushed
the
develop/ram-console-option-known-addr-buf
branch
from
cbf420b to
47d631a
Compare
JiafeiPan
approved these changes
Jun 3, 2024
dleach02
approved these changes
Jun 3, 2024
nordicjm
approved these changes
Jun 4, 2024
|
@carlocaione could you please refresh your +1? thanks! |
carlocaione
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added an option for RAM console driver to locate the console buffer to a predefined memory region, so that the RAM console can be used easily, and also added an example on imx8mmevk.