drivers: serial: uart_async_rx: Improvements in uart_async_rx module #68403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: UART
Removing a field which was redundant. It was only incremented but never read. Signed-off-by: Krzysztof Chruściński <[email protected]>
Add buffer releasing to consuming function to allow better buffer utilization since buffer is available earlier. Note that releasing in claiming function is still needed as there are cases when there are empty but completed buffers and those need to be consumed in claiming phase. Signed-off-by: Krzysztof Chruściński <[email protected]>
Return availability of free buffers after data is consumed. This information may be important for the module using uart_async_rx to schedule next reception if there is a new buffer available. Signed-off-by: Krzysztof Chruściński <[email protected]>
nordic-krch
force-pushed
the
uart_async_rx_fix
branch
from
9131e07 to
d3a7130
Compare
There was a wrong order of conditions checking. First indexes were compared and then completed flag was checked. It was possible that after checking first condition context is preempted and new data is written to the buffer and completed flag is set. In that case both conditions are met but data added in preemption is dropped. In order to avoid that completed flag must be checked first. Signed-off-by: Krzysztof Chruściński <[email protected]>
Since there is only one consumer of the data stored in the buffers, it is enough to have one read index variable which can be stored in the data associated with the module and not in the buffer space (where there is a read index for each buffer). Additionally, we can safely assume that module works with small buffers so 127 byte limit is enough. Based on that assumption completed flag can be stored on a single byte together with write index. After this change, control data for each buffer takes 1 byte (3 bytes previously). Signed-off-by: Krzysztof Chruściński <[email protected]>
dcpleung
approved these changes
Feb 12, 2024
nashif
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few improvements.