Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mbox mailbox driver support #68303

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Mbox mailbox driver support #68303

merged 2 commits into from
Feb 2, 2024

Conversation

TomasGalbickaNXP
Copy link
Contributor

@TomasGalbickaNXP TomasGalbickaNXP commented Jan 30, 2024 •
edited
Loading

This PR adds new mbox driver for NXP mailbox IP.
Updates mbox related samples/tests for lpcxpresso55s69_cpu0 platform which is using new mbox_nxp_mailbox driver.

./scripts/twister --device-testing --device-serial /dev/ttyUSB0 --device-serial-baud 115200 -p lpcxpresso55s69_cpu0 --test tests/drivers/mbox/mbox_data/drivers.mbox_data --test samples/drivers/mbox/sample.drivers.mbox.real_hw --test samples/drivers/mbox_data/sample.drivers.mbox_data.real_hw --west-flash
INFO    - Using Ninja..
INFO    - Zephyr version: zephyr-v3.5.0-4976-gbb5574b505c9
INFO    - Using 'zephyr' toolchain.
INFO    - Building initial testsuite list...
INFO    - Writing JSON report /home/tom/zephyrproject/zephyr/twister-out/testplan.json

Device testing on:

| Platform             | ID   | Serial device   |
|----------------------|------|-----------------|
| lpcxpresso55s69_cpu0 |      | /dev/ttyUSB0    |

INFO    - JOBS: 20
INFO    - Adding tasks to the queue...
INFO    - Added initial list of jobs to queue
INFO    - Total complete:    3/   3  100%  skipped:    0, failed:    0, error:    0
INFO    - 3 test scenarios (3 test instances) selected, 0 configurations skipped (0 by static filter, 0 at runtime).
INFO    - 3 of 3 test configurations passed (100.00%), 0 failed, 0 errored, 0 skipped with 0 warnings in 19.60 seconds
INFO    - In total 6 test cases were executed, 0 skipped on 1 out of total 676 platforms (0.15%)
INFO    - 3 test configurations executed on platforms, 0 test configurations were only built.

Hardware distribution summary:

| Board                | ID   |   Counter |
|----------------------|------|-----------|
| lpcxpresso55s69_cpu0 |      |         3 |

@zephyrbot zephyrbot added area: Samples Samples platform: NXP Drivers NXP Semiconductors, drivers area: Devicetree Binding PR modifies or adds a Device Tree binding area: mbox labels Jan 30, 2024
@zephyrbot
Copy link
Collaborator

zephyrbot commented Jan 30, 2024 •
edited
Loading

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_nxp zephyrproject-rtos/hal_nxp@ae43870 zephyrproject-rtos/hal_nxp@0463d6a (master) zephyrproject-rtos/[email protected]

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@zephyrbot zephyrbot added manifest manifest-hal_nxp DNM This PR should not be merged (Do Not Merge) labels Jan 30, 2024
@kartben kartben assigned carlocaione and unassigned kartben Jan 30, 2024
carlocaione
carlocaione previously approved these changes Feb 1, 2024
View reviewed changes
dbaluta
dbaluta previously approved these changes Feb 1, 2024
View reviewed changes
iuliana-prodan
iuliana-prodan requested changes Feb 1, 2024
View reviewed changes
drivers/mbox/mbox_nxp_mailbox.c Show resolved Hide resolved
dts/bindings/mbox/nxp,mbox-mailbox.yaml Outdated Show resolved Hide resolved
@TomasGalbickaNXP TomasGalbickaNXP dismissed stale reviews from dbaluta and carlocaione via 04b3809 February 1, 2024 13:53
iuliana-prodan
iuliana-prodan previously approved these changes Feb 1, 2024
View reviewed changes
carlocaione
carlocaione previously approved these changes Feb 1, 2024
View reviewed changes
dleach02
dleach02 previously approved these changes Feb 1, 2024
View reviewed changes
@TomasGalbickaNXP
drivers: mbox: Add NXP Mailbox driver for mbox
c8f0cee 
This adds new NXP mailbox driver for MBOX device.

NXP mailbox IP driver supports sending data between cores.
It uses 32 bit register to trigger irq to other core.
This driver implementation uses 4 bits for channel selection of
triggering mode, 4 bits for channel selection of data transfer and
rest 24 bits for data.

NXP mailbox IP Reference Manual UM11126, Chapter 52.
https://www.nxp.com/webapp/Download?colCode=UM11126

Signed-off-by: Tomas Galbicka <[email protected]>
@TomasGalbickaNXP
Copy link
Contributor Author

Few minor fixes, remove redundant code and add comment. https://github.com/zephyrproject-rtos/zephyr/compare/04b3809396844423abef20e9bd96ff5f3d070215..f9eceb8e34d91b89c10a3d2cac0b59d30c9cf992
And rebase to current main and fix merge conflict.

carlocaione
carlocaione previously approved these changes Feb 2, 2024
View reviewed changes
iuliana-prodan
iuliana-prodan previously approved these changes Feb 2, 2024
View reviewed changes
@TomasGalbickaNXP
samples: tests: mbox: Add lpcpresso55s69 support
1998e0b 
This commit adds support for NXP board LPCXpresso55S69 for mbox.
 - samples/drivers/mbox/ - mbox signaling mode
 - samples/drivers/mbox_data/ - mbox data transfer mode
 - tests/drivers/mbox/mbox_data/ - mbox test to verify functionality.

Signed-off-by: Tomas Galbicka <[email protected]>
@zephyrbot zephyrbot removed the DNM This PR should not be merged (Do Not Merge) label Feb 2, 2024
@dleach02 dleach02 requested a review from carlocaione February 2, 2024 13:42
@dleach02
Copy link
Member

dleach02 commented Feb 2, 2024

@iuliana-prodan @carlocaione, the HAL west.yml has been updated. Can we get your re-approvals.

@MaureenHelm MaureenHelm merged commit 73d6c33 into zephyrproject-rtos:main Feb 2, 2024
21 of 22 checks passed
@TomasGalbickaNXP TomasGalbickaNXP deleted the mbox-mailbox-driver-support branch February 8, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaluta dbaluta dbaluta left review comments

@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

@dleach02 dleach02 dleach02 approved these changes

@carlocaione carlocaione carlocaione approved these changes

@mmahadevan108 mmahadevan108 Awaiting requested review from mmahadevan108

@danieldegrasse danieldegrasse Awaiting requested review from danieldegrasse

@decsny decsny Awaiting requested review from decsny

@galak galak Awaiting requested review from galak

@kartben kartben Awaiting requested review from kartben

@manuargue manuargue Awaiting requested review from manuargue

@nashif nashif Awaiting requested review from nashif

Assignees

@carlocaione carlocaione

Labels
area: Devicetree Binding PR modifies or adds a Device Tree binding area: mbox area: Samples Samples manifest manifest-hal_nxp platform: NXP Drivers NXP Semiconductors, drivers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TomasGalbickaNXP @zephyrbot @dleach02 @dbaluta @carlocaione @iuliana-prodan @kartben @MaureenHelm