Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bluetooth: Controller: Fix CIS accept fails with unsupp parameters #68227

Conversation

cvinayak
Copy link
Contributor

@cvinayak cvinayak commented Jan 29, 2024

Fix CIS accepted by Host being failed in the Controller with
reason 0x20 Unsupported LL Parameter Value, but relaxing the
check that the ACL connection is sufficiently placed such
that the time reservation using in the Controller
implementation does not overlap with the CIG event.

Fixes #60132.

@cvinayak
Copy link
Contributor Author

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 14:29:39.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from baea080 to c5bacda Compare January 29, 2024 19:01
@cvinayak
Copy link
Contributor Author

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 20:04:52.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@cvinayak
Copy link
Contributor Author

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 21:02:53.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@cvinayak
Copy link
Contributor Author

#AutoPTS run zephyr BAP/USR/SCC/BV-135-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 06:05:59.

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful testsBAP BAP/USR/SCC/BV-135-C PASS

@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from 51ea017 to 2900e92 Compare February 2, 2024 12:08
@cvinayak cvinayak changed the title Bluetooth: Controller: Make PERIPHERAL_ISO_EARLY_CIG_START the default Bluetooth: Controller: Fix CIS accept fails with unsupp parameters Feb 2, 2024
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 2, 2024

#AutoPTS run zephyr BAP/USR/SCC/BV-135-C BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 13:14:42.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established
Successful testsBAP BAP/USR/SCC/BV-135-C PASS

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 2, 2024

#AutoPTS run zephyr BASS/SR/CP/BV-04-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 15:05:41.

@codecoup-tester
Copy link

AutoPTS Bot results:
No failed test found.

Successful testsBASS BASS/SR/CP/BV-04-C PASS - ERRATA https://github.com//issues/64449 Missing notifications

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 2, 2024

#AutoPTS run zephyr BASS/SR/CP/BV-04-C BASS/SR/CP/BV-05-C BASS/SR/CP/BV-06-C BASS/SR/CP/BV-07-C BASS/SR/CP/BV-12-C BASS/SR/CP/BV-13-C BASS/SR/CP/BV-14-C BASS/SR/CP/BV-15-C BASS/SR/CP/BV-17-C BASS/SR/CP/BV-18-C BASS/SR/CP/BV-19-C BASS/SR/CP/BV-20-C BASS/SR/SPE/BI-05-C BASS/SR/SPE/BI-06-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 17:52:17.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBASS BASS/SR/CP/BV-13-C FAIL - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-15-C BTP ERROR - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-19-C FAIL - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-20-C FAIL - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/SPE/BI-06-C FAIL - ERRATA https://github.com//issues/64449 Missing notifications
Successful testsBASS BASS/SR/CP/BV-04-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-05-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-06-C PASS - ERRATA https://github.com//issues/64449 Missing notifications and https://bluetooth.atlassian.net/browse/ES-24765
BASS BASS/SR/CP/BV-07-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-12-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-14-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-17-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/CP/BV-18-C PASS - ERRATA https://github.com//issues/64449 Missing notifications
BASS BASS/SR/SPE/BI-05-C PASS - ERRATA https://github.com//issues/64449 Missing notifications

@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from 2900e92 to 8a56d9f Compare February 9, 2024 09:12
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

AutoPTS Bot results:
Failed tests
BASS BASS/SR/CP/BV-13-C FAIL - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-15-C BTP ERROR - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-19-C FAIL - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-20-C FAIL - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/SPE/BI-06-C FAIL - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
Successful tests
BASS BASS/SR/CP/BV-04-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-05-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-06-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications and https://bluetooth.atlassian.net/browse/ES-24765
BASS BASS/SR/CP/BV-07-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-12-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-14-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-17-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/CP/BV-18-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications
BASS BASS/SR/SPE/BI-05-C PASS - ERRATA https://github.com/[/issues/64449](https://github.com/zephyrproject-rtos/zephyr/issues/64449) Missing notifications

@mkasenberg could check if the above failures still related to #64449 which I believe is fixed upstream.

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 10:18:33.

@codecoup-tester
Copy link

AutoPTS Bot failed:
Build and flash step failed

@mkasenberg
Copy link
Contributor

@mkasenberg could check if the above failures still related to #64449 which I believe is fixed upstream.

No, the issue with missing notifications is fixed indeed. The failures are related to something in app or host layer.

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 11:11:23.

@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from 6b02024 to 8a56d9f Compare February 9, 2024 10:23
@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from 8a56d9f to e7cb459 Compare February 9, 2024 14:36
@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 15:38:45.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@cvinayak
Copy link
Contributor Author

cvinayak commented Feb 9, 2024

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C BAP/UCL/STR/BV-526-C BAP/UCL/STR/BV-527-C BAP/UCL/STR/BV-528-C BAP/UCL/STR/BV-529-C BAP/UCL/STR/BV-531-C BAP/UCL/STR/BV-532-C BAP/UCL/STR/BV-533-C BAP/USR/STR/BV-362-C BAP/USR/STR/BV-365-C BAP/USR/STR/BV-366-C BAP/USR/STR/BV-377-C BAP/USR/STR/BV-380-C BAP/USR/STR/BV-383-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 16:47:06.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-526-C PTS TIMEOUT - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-527-C PTS TIMEOUT - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-528-C PTS TIMEOUT - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-531-C PTS TIMEOUT - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-532-C FATAL ERROR - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-362-C INCONC - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-365-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-366-C INCONC - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-377-C INCONC - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-380-C PTS TIMEOUT - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/USR/STR/BV-383-C INCONC - ERRATA https://github.com//issues/60132 2th CIS not established
Successful testsBAP BAP/UCL/STR/BV-529-C PASS - ERRATA https://github.com//issues/60132 2th CIS not established
BAP BAP/UCL/STR/BV-533-C PASS (3) - ERRATA https://github.com//issues/60132 2th CIS not established

@mkasenberg
Copy link
Contributor

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 13:38:31.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

Fix CIS accepted by Host being failed in the Controller with
reason 0x20 Unsupported LL Parameter Value, but relaxing the
check that the ACL connection is sufficiently placed such
that the time reservation using in the Controller
implementation does not overlap with the CIG event.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Some peer controller implementations are not able to
establish CIS if the instant is equal to the current event
count where CIS_IND PDU is received. Workaroud by having
the instant one ahead of the event count where CIS_IND PDU
is transmitted.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Do not use PERIPHERAL_ISO_EARLY_CIG_START, instead CIS offset
minimum check is relaxed permitting the minimum of 500 us
offset to be accepted by our peripheral implementation.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Handle reception of valid ISO data only.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
Fix Central ISO sub_interval calculation, include active
clock jitter in the calculation.

Signed-off-by: Vinayak Kariappa Chettimada <[email protected]>
@cvinayak cvinayak force-pushed the github_peripheral_iso_early_cig_start_default branch from e7cb459 to ab9dcad Compare February 12, 2024 14:44
@cvinayak
Copy link
Contributor Author

#AutoPTS run zephyr BAP/UCL/STR/BV-525-C

@codecoup-tester
Copy link

Scheduled PR ##68227 (comment) after 15:59:52.

@codecoup-tester
Copy link

AutoPTS Bot results:

Failed testsBAP BAP/UCL/STR/BV-525-C FAIL - ERRATA https://github.com//issues/60132 2th CIS not established

@github-actions github-actions bot added the Stale label Apr 13, 2024
@zephyrproject-rtos zephyrproject-rtos deleted a comment from github-actions bot Apr 15, 2024
@cvinayak cvinayak removed the Stale label Apr 15, 2024
Copy link

This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jun 15, 2024
@cvinayak
Copy link
Contributor Author

Closing see: #60132 (comment)

@cvinayak cvinayak closed this Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LE Audio: Controller: Failed to establish a second CIS with Packetcraft controller
3 participants