Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Analog AD559x MFD driver I2C bus access #68048

Merged
merged 2 commits into from
Apr 1, 2024
Merged

Add Analog AD559x MFD driver I2C bus access #68048

merged 2 commits into from
Apr 1, 2024

Conversation

jeppenodgaard
Copy link
Collaborator

@jeppenodgaard jeppenodgaard commented Jan 24, 2024 •
edited
Loading

This PR renames and refactors the existing code and adds I2C support.

@jeppenodgaard jeppenodgaard force-pushed the jepod/ad559x branch 3 times, most recently from 850b2dd to 287a8eb Compare January 24, 2024 12:15
@jeppenodgaard jeppenodgaard changed the title Jepod/ad559x Add Analog AD5592 MFD driver I2C bus access Jan 24, 2024
@jeppenodgaard jeppenodgaard changed the title Add Analog AD5592 MFD driver I2C bus access Add Analog AD559x MFD driver I2C bus access Jan 24, 2024
@jeppenodgaard jeppenodgaard force-pushed the jepod/ad559x branch 8 times, most recently from 6c5de17 to ca36704 Compare January 26, 2024 14:13
@jeppenodgaard jeppenodgaard marked this pull request as ready for review January 26, 2024 14:14
@jeppenodgaard jeppenodgaard requested a review from bbilas as a code owner January 26, 2024 14:14
@zephyrbot zephyrbot added area: I2C area: GPIO area: MFD area: ADC Analog-to-Digital Converter (ADC) platform: ADI Analog Devices, Inc. area: Devicetree Binding PR modifies or adds a Device Tree binding area: DAC Digital-to-Analog Converter labels Jan 26, 2024
@jeppenodgaard
Copy link
Collaborator Author

@jeppenodgaard I have tested driver in your initial version (before review changes) on HW I have got and it seems to work fine.

Thank you so much!
I might am currently trying to figure out how to refactor so e.g. adc wont be part of mfd header, so there will probably come more changes, but they should not be functional changes.

@zephyrbot zephyrbot requested a review from decsny March 4, 2024 14:51
@jeppenodgaard
Copy link
Collaborator Author

@bbilas @aasinclair I refactored the code and implemented it slightly different than I suggested by using a config flag and a mdf function to get the flag. I also squashed commits to ensure it builds. Please have a look.

@jeppenodgaard
Copy link
Collaborator Author

Ping @bbilas

@carlescufi carlescufi assigned bbilas and unassigned anangl Mar 21, 2024
@henrikbrixandersen
Copy link
Member

@jeppenodgaard You need to resolve the merge conflicts.

@fabiobaltieri
Copy link
Member

CI fail is unrelated, @aescolar can you take a look? west build -p -b nrf5340bsim/nrf5340/cpuapp -T samples/drivers/mbox/sample.drivers.mbox.simu fails but nrf5340bsim/nrf5340/cpuapp is explicitly allowed in samples/drivers/mbox/sample.yaml

@aescolar
Copy link
Member

CI fail is unrelated..

@fabiobaltieri thanks for the ping, issue #70566, fix is being tested

fabiobaltieri
fabiobaltieri previously approved these changes Mar 21, 2024
View reviewed changes
@bbilas
Copy link
Collaborator

bbilas commented Mar 22, 2024

Could you move cd42487020dd59dbd79712ea9c8aa67af57b1898 and 7475fa0fac704efe9c2b22e8b14d71d3140e4bca into separate PR?

@jeppenodgaard
Copy link
Collaborator Author

Could you move cd42487020dd59dbd79712ea9c8aa67af57b1898 and 7475fa0fac704efe9c2b22e8b14d71d3140e4bca into separate PR?

Yes:
#70600

@bbilas
Copy link
Collaborator

bbilas commented Mar 28, 2024

@jeppenodgaard please rebase.

drivers: ad559x: add i2c bus support
dd1c51c 
Rename ad5592 files in dts, driver and include to ad559x and add support
for I2C bus which is required for AD5593.

Signed-off-by: Jeppe Odgaard <[email protected]>
tests: drivers: build_all: add build test for ad559x i2c driver
70ad84c 
Add build-only test of the ad559x I2C based ADC, DAC and GPIO driver.

Signed-off-by: Jeppe Odgaard <[email protected]>
@jeppenodgaard
Copy link
Collaborator Author

@jeppenodgaard please rebase.

Done :)

@MaureenHelm MaureenHelm merged commit 128e805 into zephyrproject-rtos:main Apr 1, 2024
22 checks passed
@jeppenodgaard jeppenodgaard mentioned this pull request Jun 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbilas bbilas bbilas approved these changes

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@fabiobaltieri fabiobaltieri fabiobaltieri approved these changes

@aasinclair aasinclair Awaiting requested review from aasinclair

@anangl anangl Awaiting requested review from anangl

@galak galak Awaiting requested review from galak

@gmarull gmarull Awaiting requested review from gmarull

@henrikbrixandersen henrikbrixandersen Awaiting requested review from henrikbrixandersen

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@microbuilder microbuilder Awaiting requested review from microbuilder

@mnkp mnkp Awaiting requested review from mnkp

@teburd teburd Awaiting requested review from teburd

@decsny decsny Awaiting requested review from decsny

Assignees

@bbilas bbilas

Labels
area: ADC Analog-to-Digital Converter (ADC) area: DAC Digital-to-Analog Converter area: Devicetree Binding PR modifies or adds a Device Tree binding area: GPIO area: I2C area: MFD platform: ADI Analog Devices, Inc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@jeppenodgaard @bbilas @fabiobaltieri @LukaszMadejGrinn @henrikbrixandersen @aescolar @MaureenHelm @aasinclair @anangl @zephyrbot