Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: posix: shorten the filter in testcase.yaml #67641

Merged

Conversation

cfriedt
Copy link
Member

@cfriedt cfriedt commented Jan 15, 2024

Shorten the filter in tests/posix/**/testcase.yaml. Specifically, CONFIG_NATIVE_LIBC can be used in place of CONFIG_NATIVE_BUILD and CONFIG_EXTERNAL_LIBC.

@cfriedt cfriedt force-pushed the shorten-filter-in-posix-testcase-yaml branch from 82dafef to e95365c Compare January 15, 2024 22:51
ycsin
ycsin previously approved these changes Jan 16, 2024
@cfriedt cfriedt force-pushed the shorten-filter-in-posix-testcase-yaml branch 2 times, most recently from 46dc6d1 to e95365c Compare January 16, 2024 05:10
Copy link
Member

@aescolar aescolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NATIVE_APPLICATION is mostly native_posix.
NATIVE_BUILD and EXTERNAL LIBC is either native_posix or any of the native simulator based targets when building with the host libc.
So they are not equivalent.

You can use NATIVE_LIBC though.

@cfriedt
Copy link
Member Author

cfriedt commented Jan 16, 2024

NATIVE_APPLICATION is mostly native_posix.
NATIVE_BUILD and EXTERNAL LIBC is either native_posix or any of the native simulator based targets when building with the host libc.
So they are not equivalent.

You can use NATIVE_LIBC though.

That's what it was. Thanks for the reminder.

I remembered you commented on a separate PR.

@cfriedt cfriedt force-pushed the shorten-filter-in-posix-testcase-yaml branch 2 times, most recently from 5550c9d to 45efe6d Compare January 16, 2024 18:31
@cfriedt cfriedt marked this pull request as ready for review January 16, 2024 23:59
@cfriedt cfriedt requested review from aescolar and ycsin January 16, 2024 23:59
@ycsin
Copy link
Member

ycsin commented Jan 17, 2024

oops, force pushed to wrong branch?

@cfriedt cfriedt force-pushed the shorten-filter-in-posix-testcase-yaml branch from 45efe6d to b4bc302 Compare January 17, 2024 08:38
@zephyrbot zephyrbot added the area: POSIX POSIX API Library label Jan 17, 2024
CONFIG_NATIVE_LIBC can be used in place of
CONFIG_NATIVE_BUILD and CONFIG_EXTERNAL_LIBC

Signed-off-by: Christopher Friedt <[email protected]>
@cfriedt cfriedt force-pushed the shorten-filter-in-posix-testcase-yaml branch from b4bc302 to fb28203 Compare January 17, 2024 08:41
@cfriedt cfriedt merged commit e223d01 into zephyrproject-rtos:main Jan 17, 2024
34 checks passed
@cfriedt cfriedt deleted the shorten-filter-in-posix-testcase-yaml branch January 26, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants