Bluetooth: MPL: Add notification to track change #67451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Thalley This is RFC, could you please take a look? |
Thalley
reviewed
Jan 12, 2024
piotrnarajowski
force-pushed
the
regression_review
branch
from
c9b5e59 to
8e9aa8c
Compare
Thalley
reviewed
Jan 15, 2024
piotrnarajowski
force-pushed
the
regression_review
branch
from
8e9aa8c to
c13a553
Compare
Thalley
requested changes
Jan 15, 2024
This adds notifications to do_first_track only when changing group. Before the change was made, client was never notified about track change when changing group in Media Player. Signed-off-by: Piotr Narajowski <[email protected]>
piotrnarajowski
force-pushed
the
regression_review
branch
from
c13a553 to
928d709
Compare
Thalley
approved these changes
Jan 15, 2024
zephyrbot
requested review from
asbjornsabo,
Casper-Bonde-Bose,
fredrikdanebjer,
jhedberg,
kruithofa,
larsgk,
MariuszSkamra and
sjanc
larsgk
approved these changes
Jan 15, 2024
|
@piotrnarajowski does this fix #67312? |
|
@Thalley Unfortunately no, this is separate issue |
OK, I'll look into that now then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds notifications to do_first_track. Before the change was made, client was never notified about track change when changing group in Media Player.