drivers: display: sdl: supporting display_read() and add some Kconfig options
#67447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soburi
force-pushed
the
display_read_sdl
branch
5 times, most recently
from
55c2774 to
a778871
Compare
kartben
reviewed
Jan 12, 2024
Add SDL_DISPLAY_USE_HARDWARE_ACCELEREATOR to be able to switch enable/disable hardware accelerator. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
display_read_sdl
branch
from
a778871 to
52ae156
Compare
soburi
changed the title
display_read() and add USE_HARDWARE_ACCELERATOR option
soburi
changed the title
display_read() and add USE_HARDWARE_ACCELERATOR optiondisplay_read() and add some Kconfig options
soburi
force-pushed
the
display_read_sdl
branch
3 times, most recently
from
452867b to
f7309fd
Compare
Fixed an issue where `display_read()` in the SDL driver was not working. In the current implementation, use texture to represent screen images. To read this, draw it once on another surface and then read it. Signed-off-by: TOKITA Hiroshi <[email protected]>
Added config for specifying bit order when using monochrome format. Signed-off-by: TOKITA Hiroshi <[email protected]>
Add test for `display_read()` and `display_write()` api. Note: The CI environment has no display device, which makes it fail the tests. So, I make this test case `build_only`. But it can run in a display device available environment. Signed-off-by: TOKITA Hiroshi <[email protected]>
soburi
force-pushed
the
display_read_sdl
branch
from
f7309fd to
7dedf39
Compare
aescolar
approved these changes
Jan 19, 2024
jfischer-no
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed an issue where
display_read()in the SDL driver was not working.In the current implementation, use texture to represent screen images.
To read this, draw it once on another surface and then read it.
This PR also adds tests for
display_read()anddisplay_write().But it was marked as
build_only, so it will not run in the CI environment.It will fail in the CI environment because a display device is not available.
I add the option
SDL_DISPLAY_USE_HARDWARE_ACCELERATORto run this test with the SDL software renderer.If it runs tests with a hardware accelerator, the data obtained may differ depending on the hardware, so it should use a software renderer.
This option is also useful for testing higher-level graphics functions.
I also add the
SDL_DISPLAY_MONO_MSB_FIRSToption.This option toggles the bit order for MONO01/MONO10. This is also reflected in capabilities. This is also a useful option for testing.