twister: hotfix for unimplemented harnesses #67445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nashif
added
the
Hotfix
henrikbrixandersen
previously approved these changes
Jan 10, 2024
Harness is freeform right now in the yaml file and if the harness is not implemented in class, things fail. While we cleanup and enforce implementations, this should serve as a quick fix dealing with such unimplemented harnesses. Signed-off-by: Anas Nashif <[email protected]>
nashif
force-pushed
the
topic/twister/unimplemented_harness
branch
from
758fbb1 to
dde7ea5
Compare
golowanow
approved these changes
Jan 10, 2024
gmarull
approved these changes
Jan 10, 2024
gchwier
approved these changes
Jan 10, 2024
| @@ -1055,8 +1055,9 @@ def build(self): | |||
| harness = HarnessImporter.get_harness(self.instance.testsuite.harness.capitalize()) | |||
There was a problem hiding this comment.
could be fine to keep harness in self variables, because it is also created in run method (as a new instance)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Harness is freeform right now in the yaml file and if the harness is not
implemented in class, things fail. While we cleanup and enforce
implementations, this should serve as a quick fix dealing with such
unimplemented harnesses.
Signed-off-by: Anas Nashif [email protected]