ci: update elasticsearch index with merged PR data #67332
Conversation
nashif
force-pushed
the
topic/ci/es_updates
branch
from
5f2509b to
34c36db
Compare
nashif
force-pushed
the
topic/ci/es_updates
branch
from
34c36db to
f9cf665
Compare
nashif
force-pushed
the
topic/ci/es_updates
branch
from
f9cf665 to
7ff668e
Compare
| - name: checkout | ||
| uses: actions/checkout@v3 |
There was a problem hiding this comment.
Note that the first run of this workflow is going to fail because it will check out the base branch (main) instead of the pull request head (github.event.pull_request.head.sha) -- that is a good thing because it does not expose ELASTICSEARCH_KEY wide open if someone decides to change types: [closed] to something else in the future.
scripts/ci/stats/merged_prs.py
Outdated
| if pr.assignee: | ||
| prj['assignee'] = pr.assignee.login | ||
| prj['reviewed_by_assignee'] = "yes" if pr.assignee.login in reviewers else "no" | ||
| if pr.assignee.login in reviewers or 'Hotfix' in pr.labels or pr.assignee.login == pr.user.login: |
There was a problem hiding this comment.
it's actually more than "assignee has approved" as per the merge criteria, and there should be a +1 from at least one maintainer/collaborator of each affected area.
But in fairness starting to track this might be overkill until we first provide release engineers with some tooling/UI to easily check that a given PR tick these boxes... So feel free to dismiss this comment / keep for a later update.
There was a problem hiding this comment.
yeah, and we also need the 4 eye rule thing, but that requires more data analysis and thought, can be done later.
scripts/ci/stats/merged_prs.py
Outdated
| if pr.assignee and r.user: | ||
| if r.user.login == pr.assignee.login: | ||
| assignee_reviews = assignee_reviews + 1 | ||
| prj = {} |
There was a problem hiding this comment.
It'd be great to have a succinct documentation of the schema, for example in the main() docstring? Just looking at the code it's not trivial to get a sense of what data is captured, what might be missing should one want to enhance the dataset, and how to make changes without risking "breaking" the existing schema.
nashif
force-pushed
the
topic/ci/es_updates
branch
from
7ff668e to
6eb8fdd
Compare
nashif
force-pushed
the
topic/ci/es_updates
branch
from
6eb8fdd to
07f1a3d
Compare
nashif
force-pushed
the
topic/ci/es_updates
branch
from
07f1a3d to
1a71e0c
Compare
A simple workflow that runs when a PR is merged and updates the elasticsearch index with merged PR info. The dashboard for displaying the information can be found here: https://kibana.zephyrproject.io/ Signed-off-by: Anas Nashif <[email protected]>
nashif
dismissed stale reviews from henrikbrixandersen and fabiobaltieri
via
8f28bf2
nashif
force-pushed
the
topic/ci/es_updates
branch
from
1a71e0c to
8f28bf2
Compare
|
addressed case where assignee is the merger and did not approve, merging counts as a +1, so make the stats happy, just noticed this with #66752 |
A simple workflow that runs when a PR is merged and updates the
elasticsearch index with merged PR info.
The dashboard for displaying the information can be found here:
https://kibana.zephyrproject.io/
Signed-off-by: Anas Nashif [email protected]