drivers: bluetooth: hci: Separate ST SPI vendor driver from spi.c #67258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include zephyr,bt-hci-spi.yaml in both ST HCI SPI yaml files. Signed-off-by: Ali Hozhabri <[email protected]>
Copy ST specific SPI protocol code from spi.c to a vendor specific file. Signed-off-by: Ali Hozhabri <[email protected]>
Remove ST vendor code from spi.c. Update CMakeLists to select ST vendor file for ST BlueNRG devices. Signed-off-by: Ali Hozhabri <[email protected]>
Update dts files to use ST vendor specific HCI SPI Bluetooth driver. Remove unnecessary GPIO bias for output pins. Signed-off-by: Ali Hozhabri <[email protected]>
Add support for handling ST Proprietary extended event. Signed-off-by: Ali Hozhabri <[email protected]>
HoZHel
requested review from
erwango,
alwa-nordic,
jhedberg,
Vudentz and
avisconti
as code owners
zephyrbot
added
platform: STM32
zephyrbot
requested review from
ABOSTM,
asbjornsabo,
FRASTM,
gautierg-st,
hermabe,
jori-nordic,
kruithofa,
sjanc,
Thalley and
theob-pro
jhedberg
approved these changes
Jan 9, 2024
jori-nordic
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
Still works on nRF devices.
I'll rebase #67437 when this is merged.
carlescufi
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate ST HCI SPI Bluetooth driver from spi.c to make the Zephyr driver simpler and allow future extension for ST vendor code.
This restructuring has been mentioned by @JordanYates and other people to simplify the code since SPI is not standardized by Bluetooth and it exists in several vendor specific flavors. [see also #66544].
Changes have been tested on 96b_carbon, disco_l475_iot1, b_l4s5i_iot01a,
stm32l562e_dk, x_nucleo_idb05a1, sensortile_box, and sensortile_box_pro boards.